Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set owner name and email to "default" #209

Merged
merged 4 commits into from
Apr 23, 2024
Merged

Conversation

matifali
Copy link
Contributor

Closes coder/modules#162

When the terraform plan is run, the data.coder_workspace.me.owner_email and data.coder_workspace.me.owner_name fields are blank, which causes the template build to fail.

This should resolve the issue by setting those entries to a non-empty string.

Closes coder/modules#162

When the terraform plan is run, the `data.coder_workspace.me.owner_email` and `data.coder_workspace.me.owner_name` fields are blank, which causes the template build to fail. 

This should resolve the issue by setting those entries to a non-empty string.
provider/workspace.go Outdated Show resolved Hide resolved
Copy link
Member

@johnstcn johnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add a unit test to validate this behaviour, and we should probably also validate that this only happens during the plan phase; if these values are unset at the apply stage then this is a pretty big bug somewhere in the coder <-> provider interface.

@matifali
Copy link
Contributor Author

We should add a unit test to validate this behaviour, and we should probably also validate that this only happens during the plan phase; if these values are unset at the apply stage, then this is a pretty big bug somewhere in the coder <-> provider interface.

I would be happy if someone could take this from here and add the tests. I opened this, considering its a smaller change. I am yet to feel confident about my Go skills.

@mtojek mtojek self-assigned this Apr 17, 2024
@mtojek mtojek requested a review from johnstcn April 23, 2024 14:34
@mtojek mtojek merged commit 8c5e8ff into main Apr 23, 2024
11 checks passed
@mtojek mtojek deleted the matifali/set-default-owner branch April 23, 2024 14:40
@github-actions github-actions bot locked and limited conversation to collaborators Apr 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Git config 1.0.3 Call to function "coalesce" failed: no non-null, non-empty-string arguments.
3 participants