detail roadmap #83
detail roadmap #83
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/coderhood/coderhood/8u3199ia8 |
📝Changed routes:
Commit 83837fc (https://coderhood-git-feature-74-roadmap-detail.coderhood.now.sh). |
![Screenshot of /roadmaps/[name]](https://images.weserv.nl?url=https://s.microlink.io/UwMh4np0Zz6pIzpQS62vkML_Q8A_.png&w=600)
api/roadmaps/index.ts
Outdated
| @@ -5,12 +5,12 @@ export * from './types'; | |||
|
|
|||
| export const getRoadmaps = () => { | |||
| return fetch<GetRoadmapsResponse>( | |||
| `${process.env.NEXT_PUBLIC_BASE_URL}/roadmaps` | |||
There was a problem hiding this comment.
para que sacaste estas /? el build esta fallando por esto 🤔
components/CardTech.tsx
Outdated
| Heading, | ||
| } from '@chakra-ui/core'; | ||
|
|
||
| const CardTech = ({ image, title, description }) => { |
There was a problem hiding this comment.
podes agregarle un interface con el tipado de esto?
components/CardTech.tsx
Outdated
| <Flex flexDirection="column"> | ||
| <Text | ||
| color={colorMode === 'light' ? 'gray.800' : 'gray.300'} | ||
| fontFamily="DM Sans" |
There was a problem hiding this comment.
Creo que cambiamos DM Sans por Poppins puede ser? preguntale a @SantyLorenzo sobre si seguir usando DM Sans por las dudas
components/button/Button.tsx
Outdated
| fontWeight: 'bold', | ||
| textTransform: 'uppercase', | ||
| }, | ||
| // Two sizes: sm and md |
There was a problem hiding this comment.
Estos comentarios no son necesarios, el codigo es autoexplicativo en los nombres baseStyle, sizes y variants
No description provided.