New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Something wrong with package exports #724
Closed
2 tasks done
Comments
nicksrandall
added
bug
Something isn't working
triage
New issues that needs consideration
labels
Feb 17, 2023
nicksrandall
added a commit
to nicksrandall/sandpack
that referenced
this issue
Feb 17, 2023
ohhhh exports... @DeMoorJasper does it make sense for you? I'm not an expert on exports |
DeMoorJasper
pushed a commit
that referenced
this issue
Feb 20, 2023
I noticed that sandpack/sandpack-client/package.json Lines 16 to 18 in affdbd5
.js in import/require.
Maybe "./clients/node": {
- "import": "./dist/clients/node/index.js",
+ "import": "./dist/clients/node/index.mjs",
"require": "./dist/clients/node/index.js" FYI: publint will be helpful(This ESM and CJS decision seems buggy). |
danilowoz
pushed a commit
that referenced
this issue
Feb 20, 2023
olekxandr
pushed a commit
to olekxandr/sandpack
that referenced
this issue
Sep 20, 2023
Co-authored-by: Danilo Woznica <danilowoz@gmail.com> fix codesandbox/sandpack#724 fix codesandbox/sandpack#677
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Bug report
Packages affected
Description of the problem
Error from esbuild
What were you doing when the problem occurred?
Trying to build an app using esbuild.
Your Environment
The text was updated successfully, but these errors were encountered: