fix(sandpack-react): fix autoReload and honor showRunButton false #907
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this pull request introduce?
This fixes a bug where
autoReload={false}
doesn't turn off auto reload on code change. Additionally, it changes the logic for the Run button so thatshowRunButton={false}
is honored even whenautoReload
is off.What is the current behavior?
autoReload
is set tofalse
and a file is edited, the preview automatically reloads anyway.autoReload
andshowRunButton
are set tofalse
the code editor shows the Run button.What is the new behavior?
autoReload={false}
will prevent the preview from reloading when the code changes.showRunButton={false}
will prevent the Run button from ever appearing.What steps did you take to test this? This is required before we can merge, make sure to test the flow you've updated.
sandpack-react/src/components/CodeEditor/CodeEditor.stories.tsx
using Storybook to test when the Run button was shown or hidden.The following will hide the Run button and not automatically reload the preview:
Checklist