feat: use node v20.12.1 and node-slim image instead of alpine #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codfish
force-pushed
the
node-version
branch
4 times, most recently
from
8920bc0
to
b754611
Compare
|
🎉 This PR is included in version 3.3.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
codfish
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #204
Description
https://www.google.com/search?q=Alpine+image+DNS+issues&oq=Alpine+image+DNS+issues&gs_lcrp=EgZjaHJvbWUyBggAEEUYOTIKCAEQABiABBiiBDIKCAIQABiABBiiBNIBBzE1OWowajeoAgCwAgA&sourceid=chrome&ie=UTF-8#ip=1
Been brought to my attention by devops coworkers that alpine comes with a lot of gotchas and we've seen DNS issues with self-hosted runners using alpine.
In an effort to mitigate the risk of any number of unknown edge cases while still achieving a large image size reduction, I'm updating the image to node's official
slimvariant instead ofalpine(and bumping to 20.12.1 while I'm at it)CC @rdash99
--no-install-recommends,rm -rf /var/lib/apt/lists/*The two main dependencies needed are the node runtime and
git, so a bit larger than alpine but still seeing a 2.8x (64.4%) size reduction with slim (1.24GB -> 439MB).