Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make wheels for Python 3.5 #69

Open
codypiersall opened this issue Sep 1, 2020 · 0 comments
Open

Make wheels for Python 3.5 #69

codypiersall opened this issue Sep 1, 2020 · 0 comments

Comments

@codypiersall
Copy link
Owner

When updating CI to GitHub Actions, I noticed that Python 3.5 no longer works and builds properly. I think it's because Trio doesn't support Python 3.5 anymore.

It's a shame for pynng to not provide wheels for Python 3.5 just because of an optional integration with trio. We should some way or another. Here are some options:

  • Use a requirements file, and load from it for CI. For building wheels this is probably my preference; there's no reason to always just use the latest of all dependencies, we just want to build some wheels.
  • Slightly less preferable is to just skip the trio tests on 3.5. It would be slightly easier (less guesswork) than coming up with a definitely-working environment though.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant