Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multiple on one page #101

Open
DarinBeard opened this issue Aug 9, 2022 · 6 comments
Open

multiple on one page #101

DarinBeard opened this issue Aug 9, 2022 · 6 comments
Assignees

Comments

@DarinBeard
Copy link

I think from a 30 second peek at the code that this can only be used for one input on the page because it is targeting the button by a specific ID. Or am I wrong?

@coliff coliff self-assigned this Aug 15, 2022
@coliff
Copy link
Owner

coliff commented Aug 15, 2022

heya- it doesn't target the input based on the ID (since v1.1.0).

Though it isn't intended to be used on more than 1 on a page. I can't think of a valid use-case where that would be necessary. Could you let me know why you'd want more than one on a page? You should never be able to see other users passwords since they wouldn't/shouldn't be stored in plain-text.

@DarinBeard
Copy link
Author

Sure. I have a form for creating an account and it has a password, confirm password and security answer fields that I wanted to have a show/hide button for.

@coliff
Copy link
Owner

coliff commented Aug 15, 2022

I think if you have a 'show password toggle' button then maybe you won't need a confirm password input?

There is research showing that confirm password fields is bad UX. e.g.

@DarinBeard
Copy link
Author

Ya, I agree about confirm password, I was giving scenarios where multiple might be needed. Still the security answer though.

@mateable
Copy link

Hello what about changing passwords like input old password then have an input for new password would be nice to have it on more then one input

@ervansanjaya
Copy link

Encountering this too +1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants