Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Bootstrap 5 tests/examples/docs #3

Closed
coliff opened this issue Jul 7, 2020 · 4 comments · Fixed by #21
Closed

Add Bootstrap 5 tests/examples/docs #3

coliff opened this issue Jul 7, 2020 · 4 comments · Fixed by #21

Comments

@coliff
Copy link
Owner

coliff commented Jul 7, 2020

No description provided.

@faresbakhit
Copy link

I tried changing the Example's Bootstrap from 4.6 -> 5.0 but Unfortunately there's an issue with with the password input field

That appears to be an issue on bootstrap's side twbs/bootstrap#25110 however the issue was for inputs with right handed add-ons. it was fixed by adding has-validation however that seems not to be the case here.

@coliff
Copy link
Owner Author

coliff commented May 27, 2021

heya - I think you just need to add rounded-end (you can remove rounded-right) to the button and form input:

  <div class="input-group">
      <input type="password" id="password" name="current-password" autocomplete="current-password" class="form-control rounded" spellcheck="false" autocorrect="off" autocapitalize="off" required>
      <button id="toggle-password" type="button" class="d-none"
        aria-label="Show password as plain text. Warning: this will display your password on the screen.">
      </button>
    </div>

@faresbakhit
Copy link

@coliff Wow! Thank you so much. I has been trying find what is wrong for like half an hour before I wrote the reply but looks like I came to a wrong conclusion 😅

@coliff
Copy link
Owner Author

coliff commented May 27, 2021

:-) Happy to help. I added a Bootstrap 5 example to the project now too.

https://coliff.github.io/bootstrap-show-password-toggle/tests/bootstrap5-sign-in/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants