Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only call .catch() method when parsing fails #1674

Merged
merged 2 commits into from Dec 12, 2022
Merged

Only call .catch() method when parsing fails #1674

merged 2 commits into from Dec 12, 2022

Conversation

tmcw
Copy link
Contributor

@tmcw tmcw commented Dec 12, 2022

@netlify
Copy link

netlify bot commented Dec 12, 2022 •
edited

✅ Deploy Preview for guileless-rolypoly-866f8a ready!

Name Link
🔨 Latest commit 1e63942
🔍 Latest deploy log https://app.netlify.com/sites/guileless-rolypoly-866f8a/deploys/63977d338cb8cf000987f76c
😎 Deploy Preview https://deploy-preview-1674--guileless-rolypoly-866f8a.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@colinhacks colinhacks merged commit b3b0ecf into colinhacks:master Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

.catch callback method runs even if parsing succeeds
2 participants
@tmcw @colinhacks