feat: z.string().ulid() - add support for ulids #2049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for guileless-rolypoly-866f8a ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
chaunceyau
force-pushed
the
ulid-support
branch
from
3b2db11
to
b2215e9
Compare
|
cc @colinhacks @hugo-vrijswijk - not sure how to assign reviewers or if it's something only your team does |
chaunceyau
changed the title
Frantss
reviewed
Feb 19, 2023
deno/lib/types.ts
Outdated
| @@ -903,6 +918,9 @@ export class ZodString extends ZodType<string, ZodStringDef> { | |||
| get isCUID2() { | |||
| return !!this._def.checks.find((ch) => ch.kind === "cuid2"); | |||
| } | |||
| get isULID() { | |||
| return !!this._def.checks.find((ch) => ch.kind === "cuid2"); | |||
There was a problem hiding this comment.
probably a copy-paste mistake
Suggested change
| return !!this._def.checks.find((ch) => ch.kind === "cuid2"); | |
| return !!this._def.checks.find((ch) => ch.kind === "ulid"); |
src/types.ts
Outdated
| @@ -903,6 +918,9 @@ export class ZodString extends ZodType<string, ZodStringDef> { | |||
| get isCUID2() { | |||
| return !!this._def.checks.find((ch) => ch.kind === "cuid2"); | |||
| } | |||
| get isULID() { | |||
| return !!this._def.checks.find((ch) => ch.kind === "cuid2"); | |||
There was a problem hiding this comment.
Same here
Suggested change
| return !!this._def.checks.find((ch) => ch.kind === "cuid2"); | |
| return !!this._def.checks.find((ch) => ch.kind === "ulid"); |
chaunceyau
force-pushed
the
ulid-support
branch
from
4c1a61e
to
04e2705
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Adds support for ulids https://github.com/ulid/spec. Shopify has really popularized these and have a lot of benefits https://news.ycombinator.com/item?id=34294693