Cache the evaluation of ParseInputLazyPath.path() for a moderate perf improvement #2137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A ParseInput's path may be evaluated multiple times, so caching the evaluation result avoids some extra array allocations. Around a 10% speedup on 'realworld'.
✅ Deploy Preview for guileless-rolypoly-866f8a ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
Thanks! Simplified the implementation a bit. |
|
Hi! The changed code is definitely simpler, but at least on my machine it wipes out the perf improvement almost completely. I am guessing that Array.prototype.concat is just fundamentally a lot slower than allocating an empty array and then pushing into it. |
|
Ah interesting. Guess getting rid of |
This reverts commit c1b94a2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, thanks for the great library, I adore the API :)
I was looking for ways to make some unintrusive improvements to the performance, and noticed since a ParseInput's path may be evaluated multiple times, caching the evaluation result avoids some extra array allocations.
Around a 10% speedup on 'realworld' on my computer.
Dunno what happened with the rest of the diff, I don't think I touched anything or had "format on save" on...