Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ulid regex #2225

Merged
merged 2 commits into from Oct 4, 2023
Merged

fix ulid regex #2225

merged 2 commits into from Oct 4, 2023

Conversation

r0ots
Copy link
Contributor

@r0ots r0ots commented Mar 21, 2023

Ulid regex is not restrictive enough and can capture longer strings than expected.

[0-9A-HJKMNP-TV-Z]{26}

With this regex, an ulid like01ARZ3NDEKTSV4RRFFQ69G5FAVA is considered valid.
This contains 27 chars, but at least 26 are validating the regex, so this returns true.

Adding ^ at the start and $ at the end ensures that the regex only validates exact matching strings.

@netlify
Copy link

netlify bot commented Mar 21, 2023

Deploy Preview for guileless-rolypoly-866f8a ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 82f4926
🔍 Latest deploy log https://app.netlify.com/sites/guileless-rolypoly-866f8a/deploys/64a5c9b7159d4e0008eeac39
😎 Deploy Preview https://deploy-preview-2225--guileless-rolypoly-866f8a.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nathanchapman
Copy link

@colinhacks able to merge this soon?

@stale
Copy link

stale bot commented Oct 3, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale No activity in last 60 days label Oct 3, 2023
@nathanchapman
Copy link

#2820 no joke 🥴

@stale stale bot removed the stale No activity in last 60 days label Oct 3, 2023
@colinhacks colinhacks merged commit cd7991e into colinhacks:master Oct 4, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants