Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MediaRecorder API frame rate no change #684

Open
adeeb1201 opened this issue May 19, 2023 · 1 comment
Open

MediaRecorder API frame rate no change #684

adeeb1201 opened this issue May 19, 2023 · 1 comment

Comments

@adeeb1201
Copy link

Description

Even after passing the frame rate to record options, the framerate remains the same.
videojs-record/4.6.0/videojs.record.min.js

audio: false,
                    video: true,
                    displayMilliseconds: false,
                    maxLength: 60,
                    videoFrameRate: 30,
                    frameRate: 30,
                    videoBitRate: 90,
                    debug: true,
                    video: {
                        // video media constraints: set resolution of camera
                        height: { min: 200, ideal: 240, max: 240 },
                        width: { min: 300, ideal: 320, max: 320 },
                        frameRate: 30,
                        videoFrameRate: 30,
                        frameWidth: 320,
                        frameHeight: 240,
                    },

Adding it anywhere does not make any difference

Steps to reproduce

pass the above options and with debug true, I can see below in log (FF 112.0.2 (64-bit))

Passing following config over MediaRecorder API. 
{
  "type": "video",
  "video": {
    "width": 320,
    "height": 240
  },
  "canvas": {
    "width": 320,
    "height": 240
  },
  "frameInterval": 10,
  "disableLogs": false,
  "recorderType": null,
  "mimeType": "video/webm",
  "webAssemblyPath": "",
  "frameRate": 200,
  "bitrate": 128,
  "initCallback": null,
  "checkForInactiveTracks": false
}

Results

as above

Expected

Was expecting to see the frameRate changed to 30

Actual

Please describe what actually happened.

Error output

If there are any errors at all, please include them here.

Additional Information

Please include any additional information necessary here. Including the following:

versions

5.6.1/RecordRTC.min.js
webrtc-adapter/8.2.2/adapter.js
videojs-record/4.6.0/videojs.record.min.js

videojs

what version of videojs does this occur with? 8.3.0

browsers

what browser(s) are affected? Make sure to test with all third-party browser extensions disabled.
FF 112.0.2 (64-bit)

OSes

what platforms (operating systems and devices) are affected?
Windows 11 64 bit

@thijstriemstra
Copy link
Member

I couldn't find any code in RecordRTC that utilizes the frameRate setting so you're right.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants