Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Package with plone/meta #25

Closed
wants to merge 32 commits into from
Closed

Refactor Package with plone/meta #25

wants to merge 32 commits into from

Conversation

1letter
Copy link
Collaborator

@1letter 1letter commented Apr 18, 2024 •
edited

  • refactor package with plone/meta
  • update imports, linting and code format
  • remove buidlout related files
  • remove deprecated imports plone.app.z3cform
  • add mx.ini
  • add a browserlayer
  • make the widget BS5 ready, use floating labels https://getbootstrap.com/docs/5.2/forms/floating-labels/

i think a new release is needed. Only for Plone 6 and higher.

some things should be do:

  • news support
  • update readme
  • update the norobot macro
  • more tests

@1letter 1letter requested a review from erral April 19, 2024 08:11
@1letter 1letter marked this pull request as ready for review April 19, 2024 08:11
@1letter 1letter marked this pull request as draft April 19, 2024 11:24
This was linked to issues Apr 19, 2024
add BS5 support for Plone 6 #18
Open
includeDependencies is not a thing in Plone 6 anymore #20
Open
Plone 6 plone.app.discussion form the question is not change on reload #24
Open
@1letter 1letter self-assigned this Apr 19, 2024
@1letter 1letter removed the request for review from erral April 19, 2024 17:00
@1letter 1letter closed this Apr 19, 2024
@1letter 1letter deleted the dev branch April 19, 2024 19:18
@1letter 1letter removed a link to an issue Apr 22, 2024
Plone 6 plone.app.discussion form the question is not change on reload #24
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@1letter 1letter

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

includeDependencies is not a thing in Plone 6 anymore add BS5 support for Plone 6
1 participant
@1letter