Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run tests located in different time zones #468

Open
niccokunzmann opened this issue Oct 21, 2022 · 1 comment
Open

Run tests located in different time zones #468

niccokunzmann opened this issue Oct 21, 2022 · 1 comment
Labels

Comments

@niccokunzmann
Copy link
Member

The tests are currently running in the timezone of the server.

#466 (comment)
shows that the TZ environment variable has an influence on the behavior of icalendar.

I would like to be sure that the tests work independent of the time zone that they run in.
tox should isolate the tests from the environment variables and as such always have TZ not set.
Can we make the tests run in different time zones?

Related Work

An idea of how to do it is in recurring_ical_events:

Possible implementation

Maybe, tox can be used to set the TZ variable when the tests are run?

@WhyNotHugo
Copy link
Contributor

WhyNotHugo commented Nov 29, 2022

When working on todoman a common pattern we noticed is test breaking depending on whether the timezone is east of UTC or west of UTC (and usually, the failure was due an actual bug).

I think usually testing with Argentina (UTC-3), Germany (UTC+1) and Japan (UTC+9) helps find a lot of bugs. It's also useful to test things close to midnight UTC, since it's a different day in different timezones.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants