Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installation issue | symfony/cache does not support 6.1 version #38

Closed
LeVadim opened this issue Jan 13, 2022 · 11 comments
Closed

Installation issue | symfony/cache does not support 6.1 version #38

LeVadim opened this issue Jan 13, 2022 · 11 comments

Comments

@LeVadim
Copy link

LeVadim commented Jan 13, 2022

Hello!

Your package does not support cache version 6.1, could you please bump it up in composer.json? Thank you!

- colopl/laravel-spanner[dev-master, v3.6.0, ..., v3.9.2] require symfony/cache ~4|~5 -> found symfony/cache[v4.0.0-BETA1, ..., 4.4.x-dev, v5.0.0-BETA1, ..., 5.4.x-dev] but the package is fixed to 6.1.x-dev (lock file version) by a partial update and that version does not match. Make sure you list it as an argument for the update command.
@taka-oyama
Copy link
Collaborator

Hi, thanks for raising the issue.

This is not possible yet because laravel 8 does not support symfony v6.
I believe it will be supported when laravel 9 is released later this month.

https://github.com/laravel/framework/blob/8.x/composer.json#L36

@LeVadim
Copy link
Author

LeVadim commented Feb 10, 2022

Hi @taka-oyama ! It is almost working now. Currently getting the following error:
ParseError {#1842
#message: "syntax error, unexpected token "readonly", expecting identifier"
#code: 0
#file: "./vendor/google/cloud-spanner/src/V1/TransactionOptions/ReadOnly.php"
#line: 16
trace: {
./vendor/google/cloud-spanner/src/V1/TransactionOptions/ReadOnly.php:16 { …}
./vendor/composer/ClassLoader.php:428 { …}
./vendor/google/gax/src/Serializer.php:363 { …}
./vendor/google/gax/src/Serializer.php:416 { …}
./vendor/google/gax/src/Serializer.php:368 { …}
./vendor/google/gax/src/Serializer.php:416 { …}
./vendor/google/gax/src/Serializer.php:126 { …}
./vendor/google/cloud-spanner/src/Connection/Grpc.php:1192 { …}
./vendor/google/cloud-spanner/src/Connection/Grpc.php:790 { …}
./vendor/google/cloud-spanner/src/Operation.php:234 { …}

Can you please check it out? Thank you.
@taka-oyama

@taka-oyama
Copy link
Collaborator

taka-oyama commented Feb 14, 2022

I'm not getting that error in my setup.
That error looks like it's coming from google/gax.
Please try updating google/gax to the latest version.

@LeVadim
Copy link
Author

LeVadim commented Feb 16, 2022

It does seem like its incompatible with PHP 8.1, that ReadOnly is a reserved name
Sample error - schmittjoh/serializer#1331

Whom would you suggest reaching out to regarding this issue? Thank you.
@taka-oyama

@LeVadim
Copy link
Author

LeVadim commented Feb 16, 2022

I have created a thread with gax-php
Link is here - googleapis/gax-php#374

@taka-oyama
Copy link
Collaborator

taka-oyama commented Feb 17, 2022

Looking at the errors again, I think this might be something google/cloud-spanner needs to fix by renaming their class.

@taka-oyama
Copy link
Collaborator

I raised the issue in google-cloud-php. Hopefully they will fix it soon.

@taka-oyama
Copy link
Collaborator

Seems like we're finally getting some progress.
https://github.com/protocolbuffers/protobuf/releases/tag/v3.20.0

Fix: add missing reserved classnames (protocolbuffers/protobuf#9458)
PHP 8.1 compatibility (protocolbuffers/protobuf#9370)

Unfortunately there is a problem building 3.20.0 (protocolbuffers/protobuf#9727) in pecl so we'll have to wait until that's resolved as well.

@taka-oyama
Copy link
Collaborator

taka-oyama commented May 26, 2022

Status update.

Protobuf v21.0 was released with the fix for PHP 8.1.

Now all we need is a fix on google-cloud-php (googleapis/google-cloud-php#5129) side and we would be able to update to PHP 8.1 which Symfony 6.1 requires.

@taka-oyama
Copy link
Collaborator

Seems like googleapis/google-cloud-php#5129 was fixed in google/cloud-spanner 1.51.0.
I updated to php 8.1 and the tests seems to pass fine.

So running composer update google/cloud-spanner should make everything work (Including symfony cache v6.1).

Please check it out.

@taka-oyama
Copy link
Collaborator

I will close this for now since my environment is working under PHP 8.1 / Symfony 6.1.

Please reopen if you continue to encounter errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants