Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error patching cpp when -review is used #344

Open
UJAM-JH opened this issue Jul 19, 2022 · 3 comments
Open

Error patching cpp when -review is used #344

UJAM-JH opened this issue Jul 19, 2022 · 3 comments

Comments

@UJAM-JH
Copy link

UJAM-JH commented Jul 19, 2022

Describe the bug
Comby fails on certain files if the -review option is used

Reproducing

  • If this is not about a matcher, please describe the bug:
    save this as comby.cpp:

void test() {
  someFunc(testA, testC, testB);
}

and run this command: DEBUG_COMBY=1 comby -review 'someFunc(:[1], :[2], :[3])' ':[1] = someOtherFunc(:[3], :[2])' comby.cpp and then accept the change. Result:

Error attempting patch, command exited with 1.
Run the command again with DEBUG_COMBY=1 set in the environment for more info.
Press any key to continue, or exit now (Ctrl-C).

Expected behavior
It should patch after accepting the change

Additional context
comby 1.8.1, running on macOS.
Using the -in-place option works as expected

@UJAM-JH UJAM-JH changed the title Error in patching cpp when -review is used Error patching cpp when -review is used Jul 19, 2022
@rvantonder
Copy link
Member

thanks, eyeballing, looks like -review should imply -in-place and that's not happening--will look into fixing :-)

@lehmacdj
Copy link

Is it possible this is a duplicate of #356?

@UJAM-JH
Copy link
Author

UJAM-JH commented Feb 23, 2023

No, the files I ran comby on did not have any spaces in the path or filename

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants