-
Notifications
You must be signed in to change notification settings - Fork 33
Changelog bot is out of control #2333
Comments
Apologies, I did not read the tasks during grooming:
I disagree on this point, we do not need team consensus to decide what should or should not be in the changelog. It should be part of a normal PR to have changelog update (if relevant).
Should be questions that dev and reviewers ask themselves on a given PR. Happy to remove the bot but not keen to have a heavy process to decide to update the changelog. |
It's been a while that I wrote this. I assume I was in the role of the scrum master and was writing this without debating it 😬 I think it was not my intended to introduce new processes but the idea was that during grooming we mention something ala "Hey, watch-out, this ticket will introduce changes which should be mentioned in the changelog" @da-kami : somehow I have the feeling you could shed some more light on this :) |
(We started by questioning changelog bot because we could agree that we almost always ignore it, because it is just too annoying to have this in every PR. Then we thought about "how could we do this PR specific" and reached the conclusion that this is not really feasible.) The basic idea behind the proposal to "add this to grooming" is to raise the awareness of having breaking changes in tickets. That said, I would not see a "hard" process around this, but a soft one. If we already are aware of a breaking change being introduced in a ticket we could add a note to the ticket recommendation to consider a changelog update. This does NOT mean that we would "carefully evaluate" that for every ticket. |
Done as part of comit-network/comit-rs#2333
Done as part of comit-network/comit-rs#2333
Done as part of comit-network/comit-rs#2333
Done as part of comit-network/comit-rs#2333
2540: Remove the changelog bot r=thomaseizinger a=tcharding Changelog bot was added to help us remember to update the changelog, after time it seems it is not achieving the desired purpose and at times it goes hyper and nags many times on a single PR. Remove the changelog bot. Fixes: #2333 Co-authored-by: Tobin C. Harding <tobin.harding@coblox.tech>
Problem
Reminding us to update the changelog file is not helpful and sometimes this bot does what it wants.
Goal
Prevent Skynet early!!!111
Examples
#2330
Tasks:
The text was updated successfully, but these errors were encountered: