Skip to content
This repository has been archived by the owner on Mar 23, 2021. It is now read-only.

Changelog bot is out of control #2333

Closed
bonomat opened this issue Mar 26, 2020 · 3 comments · Fixed by #2540
Closed

Changelog bot is out of control #2333

bonomat opened this issue Mar 26, 2020 · 3 comments · Fixed by #2540
Assignees

Comments

@bonomat
Copy link
Member

bonomat commented Mar 26, 2020

Problem

Reminding us to update the changelog file is not helpful and sometimes this bot does what it wants.

Goal

Prevent Skynet early!!!111

Examples

#2330
image.png

Tasks:

  • Remove mergify-changelog bot
  • Make basecamp announcement that breaking/notable changes should be detected during grooming and it should be indicated in the ticket if the changelog should be updated. The Scrum Master should take this step up in grooming.
@da-kami da-kami added the good first issue Good for newcomers label Apr 16, 2020
@D4nte D4nte added this to the Sprint 33 ⏫🛢 milestone Apr 21, 2020
@D4nte
Copy link
Contributor

D4nte commented Apr 22, 2020

Apologies, I did not read the tasks during grooming:

Make basecamp announcement that breaking/notable changes should be detected during grooming and it should be indicated in the ticket if the changelog should be updated. The Scrum Master should take this step up in grooming.

I disagree on this point, we do not need team consensus to decide what should or should not be in the changelog. It should be part of a normal PR to have changelog update (if relevant).

  • Is the new code tested?
  • Is the changelog updated?

Should be questions that dev and reviewers ask themselves on a given PR.

Happy to remove the bot but not keen to have a heavy process to decide to update the changelog.

@bonomat
Copy link
Member Author

bonomat commented Apr 22, 2020

It's been a while that I wrote this. I assume I was in the role of the scrum master and was writing this without debating it 😬

I think it was not my intended to introduce new processes but the idea was that during grooming we mention something ala "Hey, watch-out, this ticket will introduce changes which should be mentioned in the changelog"

@da-kami : somehow I have the feeling you could shed some more light on this :)

@da-kami
Copy link
Member

da-kami commented Apr 24, 2020

(We started by questioning changelog bot because we could agree that we almost always ignore it, because it is just too annoying to have this in every PR. Then we thought about "how could we do this PR specific" and reached the conclusion that this is not really feasible.)

The basic idea behind the proposal to "add this to grooming" is to raise the awareness of having breaking changes in tickets.
This would be a concern of grooming. Team consensus might not be especially relevant, but being aware that a ticket includes breaking changes it of interest.

That said, I would not see a "hard" process around this, but a soft one. If we already are aware of a breaking change being introduced in a ticket we could add a note to the ticket recommendation to consider a changelog update. This does NOT mean that we would "carefully evaluate" that for every ticket.

@bonomat bonomat removed the good first issue Good for newcomers label Apr 26, 2020
@tcharding tcharding self-assigned this Apr 28, 2020
tcharding added a commit to comit-network/comit-js-sdk that referenced this issue Apr 28, 2020
tcharding added a commit to comit-network/comit-js-sdk that referenced this issue Apr 28, 2020
tcharding added a commit to comit-network/comit-js-sdk that referenced this issue Apr 28, 2020
tcharding added a commit to comit-network/create-comit-app that referenced this issue Apr 28, 2020
bors bot added a commit that referenced this issue Apr 30, 2020
2540: Remove the changelog bot r=thomaseizinger a=tcharding

Changelog bot was added to help us remember to update the changelog, after time it seems it is not achieving the desired purpose and at times it goes hyper and nags many times on a single PR.

Remove the changelog bot.

Fixes: #2333

Co-authored-by: Tobin C. Harding <tobin.harding@coblox.tech>
@bors bors bot closed this as completed in 6c002f6 Apr 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants