Remove ts-ignores introduced by #2330

[luckysori]

Problem

Every API test produces a log file which needs to be named after the test. Unfortunately, with Jest this is not straightforward. In the past we used a tiny, hacky JS library to deal with this problem. After PR #2330, we instead instruct Jasmine, the testing framework Jest builds on top of, to give us the name.

That was an improvement, but we had to introduce ts-ignores to silence the compiler here

comit-rs/api_tests/src/configure_jasmine.ts

Lines 1 to 5 in 9523f7b

	jasmine.getEnv().addReporter({
	specStarted: (result) =>
	// @ts-ignore
	(jasmine.currentTestName = result.description),
	});

and here

comit-rs/api_tests/src/actor_test.ts

Lines 10 to 24 in 9523f7b

	function nActorTest(
	actorNames: ["alice", "bob", "charlie"] | ["alice", "bob"] | ["alice"],
	testFn: (actors: Actors) => Promise<void>
	): ProvidesCallback {
	return async (done) => {
	// @ts-ignore
	const name = jasmine.currentTestName;
	if (!name.match(/[A-z0-9\-]+/)) {
	// We use the test name as a file name for the log and hence need to restrict it.
	throw new Error(
	`Testname '${name}' is invalid. Only A-z, 0-9 and dashes are allowed.`
	);
	}
	const actors = await createActors(name, actorNames);

Goal

To listen to the compiler. Remove the ts-ignores and deal with the problem.

[luckysori]

@thomaseizinger I finally refined this one. You may want to add it to an epic 😄

[thomaseizinger]

Thanks @luckysori, I applied good-first-issue to this.
Anyone with TS knowledge should be able to deal with that, it is not a huge priority to us though :)

[github-actions]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

[thomaseizinger]

Removing no-activity to keep this around for people who want to pick low hanging fruit :)

[github-actions]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.