Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Christmas Island and Cocos Islands are Australian territories #305

Open
svict4 opened this issue Jan 6, 2022 · 2 comments
Open

Christmas Island and Cocos Islands are Australian territories #305

svict4 opened this issue Jan 6, 2022 · 2 comments

Comments

@svict4
Copy link
Contributor

svict4 commented Jan 6, 2022

Hey was wondering if it was worth moving Christmas Island and Cocos Islands to the Australia file, just like Norfolk Island.

Despite them having their own alpha-2 country codes, they aren't countries and are just external territories of Australia. Their public holidays are by proclamation from an Australia-appointed administrator.

@commenthol
Copy link
Owner

Hi @svict4,
My questions:

  • Are CX and CC considered being states/ regions in AU?
  • Are holidays in CX and CC mainly following the holidays in AU?

From what I see is that they are considerable different.
You may take a look at FR and the assigned oversees territories like YT or MQ. Please bear in mind that these territories strictly follow the FR holidays with one exception.

Taking a deeper look into your draft PR you can see the amount of disable rules (the ones with : false) which IMHO is not necessary if staying with the NF.yaml

I'd like to avoid complicating things. As this project is mainly about holidays following geopolitical assignments I suggest to keep the structure as is and document the holidays in their respective country code (Norfolk in NF, Cocos in CC, ...).
If you still want to integrate them in AU use the _days reference.

@commenthol
Copy link
Owner

@svict4, Ping. Any thoughts on my comments above?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants