Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-implement <Navbar> component following new design guidelines #1884

Open
emmenko opened this issue Nov 18, 2020 · 0 comments
Open

Re-implement <Navbar> component following new design guidelines #1884

emmenko opened this issue Nov 18, 2020 · 0 comments

Comments

@emmenko
Copy link
Member

emmenko commented Nov 18, 2020

Just so that we can keep track of it.

Background

The current implementation of the <Navbar> is pretty "old" and has not really been updated since years (layout and styles).

The design team did provide some improvements in the design and layout, also in regards to having more menu items (for Custom Applications). However, we never really prioritized the work here.

Task

The <Navbar> component should be re-implemented following the new design guidelines.
Furthermore, we should use emotion and not css-modules. This is important as it currently blocks the work in #1871 (related to loading css files via babel).

Design guidelines

https://commercetools.invisionapp.com/overview/MCD-1429-MC-Navigation-v-2-0-ckem9zr8kyl2m01zt0vzg7kqs/screens

@emmenko emmenko added this to Needs research in SHIELD Board - UI components via automation Nov 18, 2020
@emmenko emmenko added the 🌗 good rotation topic Good to rotate a member into Application Kit to work on this topic label Nov 18, 2020
@emmenko emmenko removed the 🌗 good rotation topic Good to rotate a member into Application Kit to work on this topic label Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

No branches or pull requests

2 participants