Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default for process accumulate option #252

Open
butenkor opened this issue Feb 16, 2018 · 1 comment
Open

Change default for process accumulate option #252

butenkor opened this issue Feb 16, 2018 · 1 comment

Comments

@butenkor
Copy link
Member

Description

For processing paged results we have very helpful function called process. Currently it's default setting for accumulate results is true which depending on amount of pages and data callback function produces, might lead to unpredictable memory consumption. Because of that on every usage we have to explicitly override defaults with process(myCallbackFn, { accumulate: false }).

Expected Behavior

Default for accumulate should be false

Current Behavior

Default for accumulate is true

@wizzy25
Copy link
Contributor

wizzy25 commented Mar 6, 2018

While this a good step forward, this is a breaking change. And I have mixed feelings about breaking the SDK in this manner. I will however support it in the JS SDK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants