fix(node): remove node 6 and 8 support (#649)

This removes node 6 and 8 support. This is a free project and our builds are getting very long so we
have to be a bit careful about what versions we test on. To be clear, this still works on Node 6 and
8 for now but we won't be maintaining that guarantee into the future so please work towards
updating. This also removes eslint, likely in favor of prettier at some future date.

BREAKING CHANGE: Removal of two major node versions, 6 and 8 from testing scheme

Author: jimthedev

.travis.yml

@@ -13,7 +13,6 @@ before_install:
 before_script:
 - git version
 script:
-- npm run lint
 - npm run test
 - npm run check-coverage
 after_success:

README.md

@@ -7,6 +7,11 @@ When you commit with Commitizen, you'll be prompted to fill out any required com
 
 ## Installing the command line tool
 
+Commitizen is currently tested against
+node 10 and 12 although it may work in
+older node. You should also have npm 6
+or greater.
+
 Installation is as simple as running the following command (if you see `EACCES` error, reading [fixing npm permissions](https://docs.npmjs.com/getting-started/fixing-npm-permissions) may help):
 
 ```

jobs/build.yml

@@ -11,12 +11,10 @@ jobs:
   strategy:
     maxParallel: 3
     matrix:
+      node-12:
+        node_version: ^12.6.0
       node-10:
         node_version: ^10.10.0
-      node-8:
-        node_version: ^8.12.0
-      node-6:
-        node_version: ^6.14.4
   steps:
   - task: NodeTool@0
     displayName: " Install Node.js"

package-lock.json

@@ -13,7 +13,6 @@
     "write-coverage": "nyc report --reporter=lcov",
     "semantic-release": "npx semantic-release",
     "start": "npm run test:watch",
-    "lint": "eslint --ignore-path .gitignore .",
     "test": "nyc --require @babel/register _mocha -- test/tests/index.js",
     "test:watch": "nodemon -q --ignore test/.tmp/ --ignore test/artifacts/ --ignore coverage/ --exec \"npm run test\" --"
   },
@@ -22,7 +21,7 @@
       "path": "./node_modules/cz-conventional-changelog"
     },
     "ghooks": {
-      "pre-commit": "npm run lint && npm run test && npm run check-coverage"
+      "pre-commit": "npm run test && npm run check-coverage"
     }
   },
   "homepage": "https://github.com/commitizen/cz-cli",
@@ -55,12 +54,6 @@
     "chai": "^4.1.2",
     "codecov.io": "0.1.6",
     "cz-conventional-changelog-default-export": "0.0.0-semantically-released.1",
-    "eslint": "5.6.0",
-    "eslint-config-standard": "12.0.0",
-    "eslint-plugin-import": "2.14.0",
-    "eslint-plugin-node": "7.0.1",
-    "eslint-plugin-promise": "4.0.1",
-    "eslint-plugin-standard": "4.0.0",
     "ghooks": "^2.0.4",
     "in-publish": "^2.0.0",
     "mocha": "5.2.0",
@@ -95,7 +88,7 @@
         "@babel/preset-env",
         {
           "targets": {
-            "node": "6"
+            "node": "10"
           }
         }
       ]
@@ -109,7 +102,7 @@
   },
   "engineStrict": true,
   "engines": {
-    "node": ">= 6"
+    "node": ">= 10"
   },
   "collective": {
     "type": "opencollective",

package.json

@@ -1,6 +1,3 @@
-/* eslint-env mocha */
-/* eslint-disable no-unused-expressions */
-
 import { expect } from 'chai';
 import path from 'path';
 

test/tests/adapter.js

@@ -1,5 +1,3 @@
-/* eslint-env mocha */
-
 import { expect } from 'chai';
 import proxyquire from 'proxyquire';
 import sinon from 'sinon';

test/tests/cli.js

@@ -1,5 +1,3 @@
-/* eslint-env mocha */
-
 import { expect } from 'chai';
 import os from 'os';
 import fs from 'fs';

test/tests/commit.js

@@ -1,5 +1,3 @@
-/* eslint-env mocha */
-
 import path from 'path';
 import { expect } from 'chai';
 import { getContent, getNormalizedConfig } from '../../src/configLoader';

test/tests/configLoader.js

@@ -1,5 +1,3 @@
-/* eslint-env mocha */
-
 import { expect } from 'chai';
 import semver from 'semver';
 

test/tests/init.js

@@ -1,5 +1,3 @@
-/* eslint-env mocha */
-
 import { expect } from 'chai';
 import { gitCz as gitCzParser, commitizen as commitizenParser } from '../../src/cli/parsers';
 

test/tests/parsers.js

@@ -1,6 +1,3 @@
-/* eslint-env mocha */
-/* eslint-disable no-unused-expressions */
-
 import { expect } from 'chai';
 
 // Bootstrap our tester

test/tests/staging.js

@@ -1,6 +1,3 @@
-/* eslint-env mocha */
-/* eslint-disable no-unused-expressions */
-
 import { expect } from 'chai';
 import { isArray, isFunction, isString } from '../../src/common/util';
 
@@ -11,9 +8,7 @@ describe('common util', function () {
     // Truthies
     expect(isArray([])).to.be.true;
     expect(isArray([1, 2, 3])).to.be.true;
-    // eslint-disable-next-line no-sparse-arrays
     expect(isArray([1, , 3])).to.be.true;
-    // eslint-disable-next-line no-array-constructor
     expect(isArray(new Array())).to.be.true;
 
     // Falsies
@@ -33,7 +28,6 @@ describe('common util', function () {
 
     // Truthies
     expect(isFunction(function () {})).to.be.true;
-    // eslint-disable-next-line no-new-func
     expect(isFunction(new Function())).to.be.true;
 
     // Falsies
@@ -59,7 +53,6 @@ describe('common util', function () {
       line
       string`
     )).to.be.true;
-    // eslint-disable-next-line no-new-wrappers
     expect(isString(new String())).to.be.true;
 
     // Falsies