Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: git-cz commit repoPath #676

Merged
merged 26 commits into from Aug 25, 2020
Merged

fix: git-cz commit repoPath #676

merged 26 commits into from Aug 25, 2020

Conversation

shixy96
Copy link
Contributor

@shixy96 shixy96 commented Oct 6, 2019

No description provided.

@shixy96 shixy96 changed the title fix(strategies): git-cz commit repoPath fix: git-cz commit repoPath Oct 6, 2019
Copy link

@fgodino fgodino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

dependabot bot and others added 22 commits April 6, 2020 07:26
Bumps [minimist](https://github.com/substack/minimist) from 1.2.0 to 1.2.3.
- [Release notes](https://github.com/substack/minimist/releases)
- [Commits](https://github.com/substack/minimist/compare/1.2.0...1.2.3)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Renovate Bot <bot@renovateapp.com>
* feature: avoid dependning on shelljs

* refactor: remove shelljs from tests

* refactor: simplify configLoader call

* fix: use shell flag when spawning npm init

Co-authored-by: hdmr14 <58992133+hdmr14@users.noreply.github.com>

* refactor: remove unused function isArray

* refactor: remove unused function isString

Co-authored-by: hdmr14 <58992133+hdmr14@users.noreply.github.com>
* fix: restore commitizen.congifLoader.load to public API

This reverts commit 468e924.

* chore: temporarily skip failing test
* docs: Update `commitlint` adapter link

* docs: Update link to commitlint adapter
We have created an adapter that is purposed for the JIRA workflow when you don't use _smart commits_. We have made sure that the adapter is well documented and easy to use.

We think that it is unique and would love for it to be recognized.
Co-authored-by: Renovate Bot <bot@renovateapp.com>
)

If using git working trees, then `.git` is a file and not a directory: This file references its own
git directory within the main working tree. `$ git rev-parse --git-dir` will always return the
directory where the `COMMIT_EDITMSG` file should be placed.
Co-authored-by: Renovate Bot <bot@renovateapp.com>
Co-authored-by: Renovate Bot <bot@renovateapp.com>
@dmwelch
Copy link
Contributor

dmwelch commented Aug 21, 2020

@shixy96 If you could rebase this, I'll merge it in ASAP. Thank you for fixing this!

While still support the old git-cz binary name. Also improve the
documentation.

Closes commitizen#761
@dmwelch dmwelch self-assigned this Aug 24, 2020
@dmwelch dmwelch merged commit 4929d03 into commitizen:master Aug 25, 2020
@commitizen-bot
Copy link

🎉 This PR is included in version 4.2.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet