Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vulnerability: Prototype Pollution via the main (merge) function #963

Open
rkristelijn opened this issue Jan 11, 2023 · 2 comments
Open

Comments

@rkristelijn
Copy link

Description

Found by vulnerability check OWASP:UsingComponentWithKnownVulnerability

Filename: merge:2.1.1 | Reference: CVE-2021-23397 | CVSS Score: 9.8 | Category: CWE-1321 | All versions of package @ianwalter/merge are vulnerable to Prototype Pollution via the main (merge) function. Maintainer suggests using @generates/merger instead.

dependency tree:

commitizen@4.2.6
  └ find-node-modules@2.1.3
    └ merge@2.1.1

caused by callumacrae/find-node-modules#18

awaiting fix to upgrade to find-node-modules@2.1.4

Steps to reproduce

  1. Clone this repo
  2. Install dependencies npm i
  3. observe vulnerability

Environment

  • commitizen@4.2.6

Wrongly raised in commitizen-tools/commitizen#654

@callumacrae
Copy link

Happy to merge the PR on find-node-modules but wanted to raise something here first - commitizen is as far as I can tell the only significant project using find-node-modules, and I'm not using it anymore either. Would the maintainers of commitizen be happy / willing to take ownership of the module? Happy to transfer ownership on both github and npm if so!

Alternatively, I believe from looking in the past that it should be pretty easy to rewrite out the dependency, and then I can archive the project :)

@rkristelijn

This comment was marked as off-topic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants