Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update conventional-commit-types dependency #107

Closed
skeggse opened this issue Jan 4, 2020 · 4 comments
Closed

update conventional-commit-types dependency #107

skeggse opened this issue Jan 4, 2020 · 4 comments

Comments

@skeggse
Copy link

skeggse commented Jan 4, 2020

Version 3.0.0 of conventional-commit-types removes the improvement commit type. For consistency with the conventional commits spec, we'd like to see this change in the commitizen CLI, and since it's a breaking change we'd need to update the dependency here. Would this be a breaking change here, too?

cc @AndersDJohnson

@skeggse
Copy link
Author

skeggse commented Jan 6, 2020

See #105.

@zanza00
Copy link

zanza00 commented Jan 7, 2020

I have a project that has both the prompt both the lint of commit messages (using commitlint) and when using the prompt by cz and choosing improvement, the lint fails which is frustrating.

I forced the v3 of conventional-commit-types in my package.json but that is not ideal

@AndersDJohnson
Copy link
Member

I am not an active maintainer of this project but I support the change in #105. 👍

@skeggse
Copy link
Author

skeggse commented Feb 10, 2020

Closed and released in 3.0.3 per #105.

@skeggse skeggse closed this as completed Feb 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants