Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stop lowercasing description if second letter is also uppercase #102

Open
revelt opened this issue Nov 25, 2019 · 7 comments · May be fixed by #134
Open

stop lowercasing description if second letter is also uppercase #102

revelt opened this issue Nov 25, 2019 · 7 comments · May be fixed by #134
Labels
help wanted

Comments

@revelt
Copy link

revelt commented Nov 25, 2019 •
edited

Currently, we lowercase the whole description of a commit, but sometimes description starts with an abbreviation and lowercasing makes it look bad:

lowercasing

Let's add an additional check, is the second letter uppercase, and if so, skip the lowercase operation. I'm talking about the line https://github.com/commitizen/cz-conventional-changelog/blob/master/engine.js#L27
@revelt revelt changed the title stop uppercasing description if second letter is also upperac stop lowercasing description if second letter is also uppercase Nov 25, 2019
@LinusU
Copy link
Contributor

LinusU commented Oct 8, 2020

PRs welcome!

@revelt
Copy link
Author

revelt commented Oct 8, 2020

ok

@revelt
Copy link
Author

revelt commented Oct 8, 2020

related #97

@revelt revelt linked a pull request Oct 8, 2020 that will close this issue
Open
@revelt
Copy link
Author

revelt commented Oct 8, 2020

@LinusU done, please review the PR! Thank you for maintaining this, I use cz every day.

@vtereshyn
Copy link

any updates here? can you please merge the PR?

@RSickenberg
Copy link

RSickenberg commented Dec 8, 2021 •
edited

omg, please yes @dmwelch

@brandondurham
Copy link

Why does this stuff sit around for so long?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: recognise all-caps strings in the subject revelt/cz-conventional-changelog
5 participants
@LinusU @brandondurham @revelt @RSickenberg @vtereshyn