feat: implement subject feedback, scope filtering, subject filtering …

[yinzara]

…and config through package.json

cz-conventional-changelog can now have its values (specifically all the defaults and maxLineWidth)
through the config.commitizen key in the package.json file. The scope now automatically becomes
lowercase (as is required for conventional changelogs) and is prompted on the same line (as it is
always short and doesn't need an additional line). The subject question now indicates the total
number of characters that are allowed based upon the maxLineWidth configuration (or 100 as it is now
by default), the length of the type, and scope. Validation prevents entering more than the allowed
number of characters with feedback of the number of characters entered. Subject will always have a
lowercase first letter and strip any trailing dots (as is required by the conventional changelog
standard). 'commitizen' and 'semantic-release' have been updated to the most recent versions
(because of current vunderabilites) and the .travisci file has been updated to reflect newer node
versions.

[yinzara]

I understand this is a little rough and there are a lot of things covered in this pull request. I'm in the process of writing a full test suite right now. Do you want me to undo any of what I've done? Any requests? Feedback?

[yinzara]

ok there are all the tests. I also implemented prettier as the project was nearly already formatted and it kept the test cases looking very nice. also added an .editorconfig file

[yinzara]

Since originally Travis was only supporting Node 4, I swapped out jest for mocha/chai as jest doesn't work for Node 4 and updated the test cases and package.json

[travi]

what's the best way to test this before integration? i thought it would be as simple as npm i yinzara/cz-conventional-changelog -D, but running git cz, as normal, results in Cannot find module 'commitizen'

[yinzara]

I would just clone my repository then run:
npm install --global .

That should make it available globally.

[travi]

sure, that could be worth a try. i normally install commitizen globally and this package locally, which works because of the config in package.json:

"config": {
    "commitizen": {
      "path": "./node_modules/cz-conventional-changelog"
    }
  }

file structure was the same, so i figured that it should have worked

[travi]

s/overwritten/overridden

[yinzara]

Hmmmm just installing it locally should have worked. Maybe it was cached? Not sure. I don't think mine was released so maybe:
npm install -D git://github.com/yinzara/cz-conventional-changelog

[travi]

Hmmmm just installing it locally should have worked.

agreed

I don't think mine was released so maybe:
npm install -D git://github.com/yinzara/cz-conventional-changelog

that should be equivalent to npm i yinzara/cz-conventional-changelog -D, which correctly results in the following in the package.json and the files matching the normal installation, from what i can tell:

"cz-conventional-changelog": "github:yinzara/cz-conventional-changelog",

either way, i dont think this has anything to do with your PR, its surly something wrong on my end or me not understanding the way the pieces of commitizen should fit together, but i though i had a pretty good idea. i'm just excited to try this out, but would also like the chance to provide feedback if i could give it a shot. since im having trouble tho, i dont want anyone to wait on merging if its good to go otherwise.

[yinzara]

Anyone have any comments on this?

[yinzara]

Btw as the project author, once this PR is merged, you can turn on the "Checks" feature to require tests to pass before a PR can be merged. If you're feeling REALLY spicy, you could enable automated PR merging with Greenkeeper after tests have passed.

[PierreBrisorgueil]

hello @yinzara thx for your work, needed that for one of my projects, since there has been no return since January I allowed myself the released here, if it interests you. I integrated your PR, added emojis and switched to es6. As soon as I have a moment I would like to devise the code to allow evolutions more easily, and possibly switch on jest and coveralls. (added Greenkeeper, travis, snyk, code climate, and semantic-release to keep this up to date easily)

if this repo resumes I would do my PR here, waiting for those wishing to participate are welcome!

[yinzara]

Thanks man! Hopefully Matt gives us some love soon and we can get all of this merged back here. I know how busy it can get though.

I had originally written the tests in Jest (as you probably see in the history of this PR) but moved them to Mocha/Chai because of support for Node 4 (which Jest does not support).

If we're ok with dropping Node 4, I believe we can move back to the Jest test suite I originally wrote. But that's again up to Matt :)

[travi]

@yinzara if i'm the Matt you;re referring to, i am not a project maintainer. i'm very excited about this contribution, but i have no power to move the integration forward

[yinzara]

LOL I completely misunderstood. Looks like it's Jim that we're actually waiting on. @jimthedev Any chance we could get some movement on this?

[travi]

@jimthedev thanks for merging. i'm excited for the new features.

i was trying to look to see if i could figure out when you would publish a new version when i noticed that the last couple commits failed to publish from travis. thought i'd at least let you know in case you expected it to publish automatically and hadn't noticed that it didn't.

[jackson-jiang]

great feature and can't wait to see the new release, is there a plan?

[commitizen-bot]

🎉 This PR is included in version 3.0.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

[travi]

it looks like i should have dug deeper into the Cannot find module 'commitizen' issues I was seeing that i thought were just local config issues preventing me from testing this before it was released. i'm seeing the same message with the latest release, unfortunately.

i'll open a new issue referencing this in hopes that we can track down the issue and get it resolved

update: #89

[yinzara]

Hmm that's very odd. Since "cz-conventional-changelog" is dependent on "commitizen", I'm surprised it could have that error.

[travi]

That was the issue. It wasn't dependant on it before. It was only marked as a dev dependency before my PR got merged. Was a pretty simple fix and was merged quickly, so it's all good now.