Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WIP as a type of change. #78

Open
hamidify opened this issue Apr 14, 2019 · 2 comments
Open

Add WIP as a type of change. #78

hamidify opened this issue Apr 14, 2019 · 2 comments

Comments

@hamidify
Copy link

There should be a work in progress tag. I think.

@revelt
Copy link

revelt commented Oct 8, 2020

If I may, I'd like to put a counter argument against this idea.

If one codes up a feature from many commits, that's fine, one can put the subject more granular, you can always describe what one did, that's fine! If one doesn't want five commits to pop up in the changelog, one can use chore but I'd just go more granular.

For example, I don't care if my feature is split across 10 commits — all feat — it's fine — imagine if problem happens and somebody wants to dig where did the bug came from? Your description and proper type (not WIP) would help to sift through many commits.

The counter argument against "WIP" is that it is still a certain, unknown type of commit! Is it chore (bump patch only) or feat (bump minor)? Because in the end, it is something and we need to bump accordingly, if it were published right away... CLI could introduce additional step to ask what to bump, but then it needs to be recorded somewhere until publishing because it's an arbitrary choice...

Do you see my point?

It might be good to have but it also introduces some headaches...

@Zhwt
Copy link

Zhwt commented Dec 4, 2020

I would suggest adding some features that can add WIP: as a prefix. For me, I'm currently adding "WIP:" manually to every commit which should be considered "not complete" using git commit --amend, though it seems not ideal at first, but introducing a "not sure" type seems more confusing...🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants