Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make lower-casing of scope optional #94

Closed
coldacid opened this issue Aug 15, 2019 · 7 comments
Closed

Make lower-casing of scope optional #94

coldacid opened this issue Aug 15, 2019 · 7 comments

Comments

@coldacid
Copy link

Using cz-conventional-changelog with non-JS projects where components and file names may be cased is problematic due to the forced lower-casing of the value typed in for the scope prompt. Lower-casing should be optional, although defaulting to on is fine.

@tsironis
Copy link

According to the conventional-commits/conventionalcommits.org#24, the casing is not enforced and the only hard requirement is to be consistent.

I could try to get a PR working if you're interested in adding a configurable option for this.

@rafalmaciejewski
Copy link

I need to stick with v2 until this will be available since we need those uppercase letters at the front of the subject (because of reasons) :/
It'd be great if anyone came up with a workaround for this.

@rafalmaciejewski
Copy link

there is already a pull request for this #96

@ATLSAPI
Copy link

ATLSAPI commented Jan 29, 2020

there is already a pull request for this #96
This PR has now merged and released in v3.1.0. Does this need closing?

@coldacid
Copy link
Author

@ATLSAPI let me update and try it out.

@coldacid
Copy link
Author

coldacid commented Jan 30, 2020

Looks like this doesn't work on Windows when using a global install as Node will grab the 3.0.1 install out of commitizen itself rather than the side-installed 3.1.0 cz-conventional-changelog, unless an explicit full path is used in .czrc

@coldacid
Copy link
Author

So apart from that caveat (which is more of a Node and commitizen config issue) it looks like the functionality itself worked. Since providing an absolute path to cz-conventional-changelog in .czrc works, I'd say that this issue is good and done. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants