Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installation of python components through ctkMacroCompilePythonScript too wide #1070

Open
RafaelPalomar opened this issue Mar 6, 2023 · 0 comments

Comments

@RafaelPalomar
Copy link

ctkMacroCompilePythonScript performs an installation step which is very wide (whole directory). This makes all build files to be installed along, i.e., the CMakeFiles directory ( SystoleOS/gentoo-overlay#75).

I think ctkMacroCompilePythonScript should not have an install step. (arguably) An install step does not fit naturally in a macro labeled with Compile. Also the user (developer) knows better what should be installed and not; i.e., SlicerMacroBuioldScriptedModule.cmake is probably a better place to do the installation step. Leaving this decision to a low level macro like ctkMacroCompilePythonScript forces the installation step to be purportedly wide.

The downside is that this will mean breaking the CTK CMake API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants