Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ctkMacroBuildQtPlugin uses ${CMAKE_LIBRARY_OUTPUT_DIRECTORY}, which might not have been set (the user also may want to have a different directory as output) #1073

Open
RafaelPalomar opened this issue Mar 22, 2023 · 0 comments

Comments

@RafaelPalomar
Copy link

ctkMacroBuildQtPlugin makes use of ${CMAKE_LIBRARY_OUTPUT_DIRECTORY}`

LIBRARY_OUTPUT_DIRECTORY "${CMAKE_LIBRARY_OUTPUT_DIRECTORY}/${MY_PLUGIN_DIR}"

This variable may have not been set by the project calling the macro. Possible solutions:

  1. Make a check and trigger an error message on `${CMAKE_LIBRARY_OUTPUT_DIRECTORY} not set.

  2. Make the PLUGIN_DIR not a relative but an absolute directory. This will need to get propagated up to ctkMacroBuildQtDesignerPlugin and further to its caller. ⚠️ WARNING ⚠️ : This change would break the API.

I would lean towards 2. The final user may want to have an output directory different from ${CMAKE_LIBRARY_OUTPUT_DIRECTORY}.

@RafaelPalomar RafaelPalomar changed the title ctkMacroBuildQtPlugin uses ${CMAKE_LIBRARY_OUTPUT_DIRECTORY}, which might not have been set ctkMacroBuildQtPlugin uses ${CMAKE_LIBRARY_OUTPUT_DIRECTORY}, which might not have been set (the user also may want to have a different directory as output) Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants