Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should be checking return code from QSqlQuery::exec #1155

Open
pieper opened this issue Nov 14, 2023 · 0 comments
Open

Should be checking return code from QSqlQuery::exec #1155

pieper opened this issue Nov 14, 2023 · 0 comments

Comments

@pieper
Copy link
Member

pieper commented Nov 14, 2023

Lines like this can lead to silently missing errors in either the SQL syntax or the values of the data:

CTK/Libs/DICOM/Core/ctkDICOMDatabase.cpp

Line 971 in f53820a

insertImageStatement.exec();

We have a loggedExect method that could be used or we could check explicitly each place we do a query.
pieper added a commit to pieper/CTK that referenced this issue Nov 14, 2023
@pieper
BUG: Fix dicom db insert with URL field
8f9f14a 
We should be checking the return value of QSqlQuery::exec
to catch problems.

Filed an issue to track this:

commontk#1155
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pieper