Status not reporting or updating correctly on PR

[WillsonHG]

open-telemetry/opentelemetry-dotnet#2677

The user's EasyCLA comment status is showing

This has a mixed message that 1) the user isn't authorized but 2) the copy tells them they are missing id on commit.

The second issue is that the bot posted twice instead of editing the original comment

The third issue is that the status did not update to 'authorized' once the user authorized themselves, only the 'checks' section was updated.

[ktmitton]

I ended up resolving it by changing the email address (even on the commit), and doing a merge of recent changes from main. Not exactly sure which thing triggered the fix to work, that's just what changed between it failing and passing.

Let me know if there's anything else I can help with!

[WillsonHG]

prestodb/presto#17055 another example @dealako Need to check the response when a user has a missing ID on commit, the cla bot is not showing correct messaging.

[WillsonHG]

open-telemetry/opentelemetry-java-instrumentation#4823

[WillsonHG]

grpc/grpc#28307

[WillsonHG]

kubernetes/website#30830

[WillsonHG]

Hi @dealako any updates for this?

[WillsonHG]

kubernetes-sigs/controller-runtime#1750

[WillsonHG]

appium/appium#16312

[WillsonHG]

kubernetes-sigs/kubebuilder-declarative-pattern#203

[dealako]

Created PR: #3418. Let's QA this set of changes:

• Updated filter to identify missing IDs from the commit list
• Updated logic that checks for previous missing IDs
• Added logic to stop processing GitHub PR when the repository is disabled

[thakurveerendras]

Hello @dealako

Issue is tested on dev site & found that all the three scenario mentioned are fixed as expected

### **Updated filter to identify missing IDs from the commit list**

Setup :

1. Add non existing email address under the system .getconfig file
2. Provide admin access at GitHub repo to test user say : thakurveerendras1
3. Get “Personal access tokens” for test user "Please see https://github.blog/2020-12-15-token-authentication-requirements-for-git-operations/ for more information."
4. Git Clone repository on local machine

Setup on PCC :

1. Add EasyCLA group
2. Configure GitHub EasyCLA App
3. CLA enforced GitHub repo

Steps :

1. Make changes on local repository say update README.md
2. Git Push changes on branch

a.      git checkout -b <branchName>
b.	git add .
c.	git status
d.	git commit -m “commit text”
e.	git push origin <branchName>
i.	add test user name : thakurveerendras1
ii.	add token key : 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
f.	Copy pull request url from cmd : https://github.com/VeerNoGithubIDOrgTest/repo02/pull/new/testbranch5

3. Past PR url & create pull request
   Results Obtains: PR is gated & “MISSING ID ON COMMIT” appears
   

• ### Updated logic that checks for previous missing IDs

Steps :

1. Make changes on local repository say update README.md
2. Git Push changes on same branch above

a.	git checkout -b <branchName>
b.	git add .
c.	git status
d.	git commit -m “commit text”
e.	git push origin -f <branchName>
i.	add test user name : thakurveerendras1
ii.	add token key : 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
f.	Copy pull request url from cmd : https://github.com/VeerNoGithubIDOrgTest/repo02/pull/new/testbranch5

3. Past PR url & create pull request
   Result : “New changes since you last viewed” appears
   

• ### Added logic to stop processing GitHub PR when the repository is disabled

Steps :

1. On PCC disable cla enforced for repos
2. Make changes on local repository say update README.md
3. Git Push changes on same branch

a.	git checkout -b <branchName>
b.	git add .
c.	git status
d.	git commit -m “commit text”
e.	git push origin -f <branchName>
i.	add test user name : thakurveerendras1
ii.	add token key : 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
f.	Copy pull request url from cmd : https://github.com/VeerNoGithubIDOrgTest/repo02/pull/new/testbranch5

4. Past PR url & create pull request
   ### Result Obtains : EasyCLA not process as expected.

[thakurveerendras]

"Missing ID on Commit " PR is not authorized when user successfully signing DocuSign as ICLA

Issue is tested on Dev site

Refer video clip :
https://images.zenhubusercontent.com/194341141/7be2249e-f984-4dd2-ac8d-6cadd36399ca/3378.mp4

[dealako]

This should be resolved now. Ready for QA.

[thakurveerendras]

Hello @dealako ,
Failed case in issue is tested on dev site & found that GitHub status is now passing as expected

Refer video clip for more details :
https://images.zenhubusercontent.com/194341141/bb3ec548-27ba-4058-9f0c-efe38d2377cf/3378__1_.mp4

[dealako]

Resolved.