Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more class fields tests #1437

Open
chicoxyzzy opened this issue Mar 21, 2019 · 3 comments
Open

Add more class fields tests #1437

chicoxyzzy opened this issue Mar 21, 2019 · 3 comments

Comments

@chicoxyzzy
Copy link
Member

chicoxyzzy commented Mar 21, 2019

Currently tests don't cover computed fields
https://bugzilla.mozilla.org/show_bug.cgi?id=1535166

@afmenez
Copy link
Contributor

afmenez commented Apr 3, 2019

Wasn't this fixed by #1440?

@ljharb ljharb closed this as completed Apr 3, 2019
@chicoxyzzy
Copy link
Member Author

chicoxyzzy commented Apr 3, 2019

Not all cases were covered by #1440
For example

class C {
    2 = 2;
    0b01 = 2;
    "hello" = 2;
}

and presence of property x in instance of

class C {
    x;
}

are still worth testing IMO

@ljharb ljharb reopened this Apr 3, 2019
@chicoxyzzy
Copy link
Member Author

@evseevdev would you be open to add more tests? If so, you may ping me in Telegram again if you need more information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants