Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more tests for the WeakReferences proposal #1476

Open
afmenez opened this issue Jun 27, 2019 · 2 comments
Open

Add more tests for the WeakReferences proposal #1476

afmenez opened this issue Jun 27, 2019 · 2 comments
Labels
ESnext Help wanted new test

Comments

@afmenez
Copy link
Contributor

afmenez commented Jun 27, 2019

There is only one test for the WeakReferences proposal, for the Weak References part. There should be at least one more test for the Finalizers part.
@afmenez afmenez mentioned this issue Jun 27, 2019
Merged
@afmenez
Copy link
Contributor Author

afmenez commented Jun 27, 2019

I added a minimal Finalizer test on #1473, but I believe additional tests are necessary for both features.

@afmenez
Copy link
Contributor Author

afmenez commented Jun 27, 2019

As noted by @chicoxyzzy , there are some sample tests here, and many more on test262.

@afmenez afmenez changed the title Implement tests to the Finalizer part of the WeakReferences proposal Add more tests for the WeakReferences proposal Jul 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ESnext Help wanted new test
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@afmenez @chicoxyzzy