Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable caching in browser #59

Open
MohamedBeydoun opened this issue May 24, 2020 · 3 comments · Fixed by #62
Open

Disable caching in browser #59

MohamedBeydoun opened this issue May 24, 2020 · 3 comments · Fixed by #62
Assignees
@idodin @aehwany @MohamedBeydoun
Labels
enhancement New feature or request good first issue Good for newcomers p0
Projects
WISP 0.3.0

Comments

@MohamedBeydoun
Copy link
Member

MohamedBeydoun commented May 24, 2020 •
edited

Should disable caching old builds to make sure user's don't have to constantly clear cache to view changes.

https://stackoverflow.com/questions/40243633/disable-nginx-cache-for-javascript-files

https://stackoverflow.com/questions/44605647/long-term-caching-with-webpack-chunkhash-and-cache-control
@MohamedBeydoun MohamedBeydoun added enhancement New feature or request good first issue Good for newcomers labels May 24, 2020
@MohamedBeydoun MohamedBeydoun added this to To do in WISP 0.2.0 via automation May 24, 2020
@MohamedBeydoun MohamedBeydoun moved this from To do to In progress in WISP 0.2.0 May 25, 2020
@MohamedBeydoun MohamedBeydoun mentioned this issue May 25, 2020
Merged
@MohamedBeydoun MohamedBeydoun linked a pull request May 25, 2020 that will close this issue
Implemented caching with webpack #62
Merged
@MohamedBeydoun MohamedBeydoun moved this from In progress to In Review in WISP 0.2.0 May 25, 2020
@MohamedBeydoun MohamedBeydoun self-assigned this May 25, 2020
@MohamedBeydoun MohamedBeydoun moved this from In Review to Merged to Dev in WISP 0.2.0 May 28, 2020
WISP 0.2.0 automation moved this from Merged to Dev to Done Jun 11, 2020
@ValerianClerc
Copy link
Member

jk this doesn't work :(

@ValerianClerc ValerianClerc reopened this Jun 24, 2020
WISP 0.2.0 automation moved this from Done to In progress Jun 24, 2020
@ValerianClerc ValerianClerc moved this from In progress to To do in WISP 0.2.0 Jun 24, 2020
@ValerianClerc ValerianClerc removed this from To do in WISP 0.2.0 Jun 24, 2020
@ValerianClerc ValerianClerc added this to To Do in WISP 0.3.0 via automation Jun 24, 2020
@MohamedBeydoun
Copy link
Member Author

we need to disable caching the index.html file from our nginx config

@aehwany aehwany self-assigned this Jun 26, 2020
@aehwany aehwany moved this from To Do to In Progress in WISP 0.3.0 Jun 26, 2020
@MohamedBeydoun MohamedBeydoun moved this from In Progress to Merged to Dev in WISP 0.3.0 Aug 8, 2020
@MohamedBeydoun
Copy link
Member Author

@aehwany 's solution in dev works (latest updates to the ui appeared after refreshing the page without clearing cache)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@idodin idodin

@aehwany aehwany

@MohamedBeydoun MohamedBeydoun

Labels
enhancement New feature or request good first issue Good for newcomers p0
Projects
WISP 0.3.0
  
Merged to Dev
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implemented caching with webpack competemcgill/wisp-ui
4 participants
@idodin @aehwany @ValerianClerc @MohamedBeydoun