Replies: 2 comments
-
This is definitely a bug - compiler.exe should be set after resolving. |
Beta Was this translation helpful? Give feedback.
0 replies
-
Thanks @apmorton for confirming it. I converted this discussion to an issue (#3997) and created a tiny PR with the fix: #3998 |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
I ran into a small, but surprising, difference between using absolute or relative paths for compilers: the
initialise()
method is not called on the compiler object when relative paths are used.Here's the relevant code. Is this semantic difference intentional? (whether using relative paths for the compiler executable is a good idea or not is a different question)
compiler-explorer/lib/handlers/compile.js
Lines 147 to 172 in 219f061
Was the intention to set
compiler.exe = exe;
when resolving relative paths?compiler-explorer/lib/handlers/compile.js
Line 145 in 219f061
Beta Was this translation helpful? Give feedback.
All reactions