Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blurring of share window & spacing comments #1121

Closed
mattgodbolt opened this issue Oct 20, 2018 · 15 comments
Closed

Blurring of share window & spacing comments #1121

mattgodbolt opened this issue Oct 20, 2018 · 15 comments
Labels
probably-wont-happen PRs are welcomed, but we do not currently plan on implementing this ui

Comments

@mattgodbolt
Copy link
Member

https://twitter.com/olafurw/status/1053737941380616192?s=19 some comments here

@mattgodbolt mattgodbolt added the ui label Oct 20, 2018
@RubenRBS
Copy link
Member

@olafurw what browser do you use?

@olafurw
Copy link

olafurw commented Oct 21, 2018

Chrome Version 69.0.3497.100 on Windows 7, this appears at zoom levels 110%, 125%, 150% and anything below 100%

Also happens in Opera 56.0.3051.52, same zoom levels.

@mattgodbolt
Copy link
Member Author

I see this on my phone, but not on my laptop. Laptop has high res display but even zoomed to 200% :
screenshot from 2018-10-22 08-01-13

I'm on Chrome 69.0.3497.100 too, but on Linux. I wonder if it's a DPI thing?

@mattgodbolt
Copy link
Member Author

Maybe a bit blurry at 125%:
screenshot from 2018-10-22 08-09-00

@RubenRBS
Copy link
Member

Can confirm that I can repro on a 1080p screen, but not on a 4k one. This seems like a Bootstrap issue to me

@mattgodbolt
Copy link
Member Author

Just re-checking. 125% still looks a bit blurry. I feel bad in saying I don't have a 1080p screen around any more to test with (!!)

@olafurw
Copy link

olafurw commented Nov 12, 2019

image

Still blurry at 110% when other stuff around it isn't. Tested on both a 1080p screen and a 1440p screen.

@apmorton
Copy link
Member

can confirm this is an issue with bootstrap, but is ultimately a bug in the browser according to them - twbs/bootstrap#22610

110% on my machine
image

disable the CSS transform that bootstrap uses to position the popover:
image

Seems like the only workaround is to disable GPU acceleration - some people mention being able to do that specifically for the popover, but I don't know how to accomplish that.

@mattgodbolt
Copy link
Member Author

Thanks @apmorton ... this is starting to sound like more work than it "ought" to be :D

@RubenRBS
Copy link
Member

I can no longer repro this. Can you check if it still happens for you? There have been some changes that might have inadvertedly worked around this issue

@olafurw
Copy link

olafurw commented Dec 24, 2019

image

110% zoom on chrome on fedora 30.

image

90% zoom on chrome on fedora 30.

Sorry, yeah this isn't the biggest issue around but thanks for keeping a focused eye on it :P

@olafurw
Copy link

olafurw commented Dec 24, 2019

Quick comment, why isn't the share dropdown made the same way the other drop downs are made? No blur there.

image

110% zoom on chrome fedora 30.

@apmorton
Copy link
Member

The TLDR of why they are different is "because bootstrap".

Basically the other menus are "Dropdowns" in bootstrap, which are really only allowed to contain lists of links or buttons.

Because the share drop-down contains some more custom layout it uses a "Modal" in bootstrap. The modal is where the bug is that causes the blurring when zoomed.

@olafurw
Copy link

olafurw commented Dec 25, 2019

If you wanna close this sucker, put your fingers in your ears and say "I don't care right now lalala" then I don't mind haha :D

@partouf partouf added the probably-wont-happen PRs are welcomed, but we do not currently plan on implementing this label Mar 29, 2021
@olafurw
Copy link

olafurw commented Jul 25, 2022

Does not happen any more and the design of the site doesn't look like this anymore.
Can close.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
probably-wont-happen PRs are welcomed, but we do not currently plan on implementing this ui
Projects
None yet
Development

No branches or pull requests

5 participants