Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing support for underscores in identifier names #46

Open
marcauberer opened this issue Jun 17, 2021 · 2 comments
Open

Missing support for underscores in identifier names #46

marcauberer opened this issue Jun 17, 2021 · 2 comments
Assignees
@Splines
Labels
bug Something isn't working cpp-compiler Issues regarding the C++ compiler java-compiler Issues regarding the Java compiler
Projects
C++ Compiler Java Compiler

Comments

@marcauberer
Copy link
Member

I wonder why we did not notice this earlier, but CCom currently does not support underscores in identifiers, which is definitely not the intended solution.
The problem is that isalnum() does not return true when the input is an underscore.
@marcauberer marcauberer added the bug Something isn't working label Jun 17, 2021
@marcauberer marcauberer self-assigned this Jun 17, 2021
@marcauberer marcauberer added this to To do - staging in C++ Compiler via automation Jun 17, 2021
@marcauberer marcauberer added this to To do in Java Compiler via automation Jun 17, 2021
@marcauberer
Copy link
Member Author

marcauberer commented Jun 17, 2021 •
edited

@Splines As far I have seen, the Java compiler is also affected by this issue.

@marcauberer marcauberer mentioned this issue Jun 19, 2021
Merged
@marcauberer marcauberer moved this from To do - staging to Done in C++ Compiler Jun 19, 2021
@Splines
Copy link
Contributor

Splines commented Jun 22, 2021

thanks for noticing, will fix this

@marcauberer marcauberer assigned Splines and unassigned marcauberer Jul 5, 2021
@marcauberer marcauberer added java-compiler Issues regarding the Java compiler cpp-compiler Issues regarding the C++ compiler labels Nov 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Splines Splines

Labels
bug Something isn't working cpp-compiler Issues regarding the C++ compiler java-compiler Issues regarding the Java compiler
Projects
C++ Compiler
Done
Java Compiler
To do
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Splines @marcauberer