Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Contains Statement #41

Merged
merged 13 commits into from
Jun 17, 2021
Merged

Contains Statement #41

merged 13 commits into from
Jun 17, 2021

Conversation

marcauberer
Copy link
Member

@marcauberer marcauberer commented Jun 11, 2021 •
edited

  • Add contains statement to cpp compiler
  • Add contains statement to grammar rules
  • Update AST diagram in README
  • Replace more runtime exceptions with custom exception classes
  • Remove file headers in cpp compiler
  • Add copyright notice
  • Code optimization
  • Refactoring

Known bug, but gonna fix that in another pr, because it affects also other components:
https://github.com/compose-generator/ccom/projects/4#card-62148577

@marcauberer marcauberer added documentation Improvements or additions to documentation enhancement New feature or request improvement Improves an existing feature labels Jun 11, 2021
@marcauberer marcauberer self-assigned this Jun 11, 2021
@marcauberer marcauberer requested a review from a team June 11, 2021 15:42
@marcauberer marcauberer changed the title Contains Statement [WIP] Contains Statement Jun 11, 2021
@marcauberer marcauberer marked this pull request as ready for review June 11, 2021 21:55
@marcauberer marcauberer added this to Done in C++ Compiler Jun 11, 2021
@marcauberer marcauberer moved this from Done to In progress in C++ Compiler Jun 11, 2021
Splines
Splines suggested changes Jun 16, 2021
View reviewed changes
compiler/cpp/src/interpreter/Interpreter.cpp Outdated Show resolved Hide resolved
compiler/cpp/src/parser/Parser.cpp Show resolved Hide resolved
media/class-diagram.drawio Outdated Show resolved Hide resolved
Splines
Splines reviewed Jun 17, 2021
View reviewed changes
media/test-file.yml Show resolved Hide resolved
compiler/cpp/src/util/JSONParser.cpp Show resolved Hide resolved
compiler/cpp/src/util/JSONParser.cpp Show resolved Hide resolved
@marcauberer marcauberer merged commit ab63963 into main Jun 17, 2021
C++ Compiler automation moved this from In progress to Done Jun 17, 2021
@marcauberer marcauberer deleted the feature/contains-stmt branch June 17, 2021 08:17
@Splines Splines mentioned this pull request Jun 17, 2021
Closed
@marcauberer marcauberer linked an issue Jun 25, 2021 that may be closed by this pull request
Contains Stmt #56
Open
@marcauberer marcauberer added this to the 0.2.0 milestone Aug 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Splines Splines Splines approved these changes

Assignees

@marcauberer marcauberer

Labels
documentation Improvements or additions to documentation enhancement New feature or request improvement Improves an existing feature size/XL
Projects
C++ Compiler
Done
Milestone
0.2.0
Development

Successfully merging this pull request may close these issues.

Contains Stmt
2 participants
@marcauberer @Splines