-
-
Notifications
You must be signed in to change notification settings - Fork 476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Packagist not updating for deletions #959
Comments
Anybody look into this? This is still an issue. I just removed an Again, I can look in the "webhook" tab in GitHub and see that it did post the deletion to Packagist:
As well as Packagist responding with:
This webhook dispatch was timestamped at |
Would you mind if I go ahead and manually clean up my repositories, or do you need more time to look at the current state to figure out why these updates aren't happening? |
Job
So it still existed.. Then job a857599b4ea54c4ff7167c6d8b59d3463f351607 started at So all works as expected, but it's not ideal when you're micro-managing things. I am not sure how we could improve this.. The point was to avoid wiping out all versions of a package in case any temporary outage returns no version (which definitely happened in the past occasionally). |
@Seldaek I think a solution could be to inspect the payload of the github webhook in detail instead of just using it as a trigger for a full processing of the package. Receiving a webhook telling the branch was deleted would allow for immediate removal of that version, as it is clear it is not an outage. |
Or offer more detailed webhooks and configure them automatically at GitHub like you do anyway. That way less coupling to GitHub, right? And probably also cheaper - incremental rather than full updates. |
any news? |
Looks like Packagist isn't picking up branch deletions today?
Under webhooks in GitHub I can see several deliveries were made today - for example:
I've made numerous changes to this repo today, of which adding tags did correctly generate new versions in Packagist - but several branch removals (all of which show webhook deliveries being made) did not.
I've marked with green here additions I made today, and removals in red:
I'll wait before I manually update, in case you want to investigate the data/logs. (Please let me know if I can safely do the manual update?)
The text was updated successfully, but these errors were encountered: