Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't use address computation nodes anywhere besides load/store node #244

Open
joshuabach opened this issue Feb 8, 2019 · 1 comment
Open

Can't use address computation nodes anywhere besides load/store node #244

joshuabach opened this issue Feb 8, 2019 · 1 comment
Labels
bug 🐞 Something isn't working wontfix This will not be worked on
Milestone
Machine Code Gene...

Comments

@joshuabach
Copy link
Contributor

We can only use address computation nodes (Sel/Member) as direct predecessors of load/store nodes. But they can be used in other cases as well. A special case of this error occurrs when there is a more complex address computation, consisting of a sel and a member node
@joshuabach joshuabach added bug 🐞 Something isn't working wontfix This will not be worked on labels Feb 8, 2019
@joshuabach joshuabach added this to the Machine Code Generation milestone Feb 8, 2019
@joshuabach
Copy link
Contributor Author

2019-02-08_18-07-sel-member

joshuabach added a commit that referenced this issue Feb 9, 2019
@joshuabach
gen_instr: Allow Sel nodes with Member nodes as direct predecessor
11600e9 
This is a hotfix for a specific symptom of a more fundamental problem,
see #244
@flip1995 flip1995 mentioned this issue Feb 10, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug 🐞 Something isn't working wontfix This will not be worked on
Projects
None yet
Milestone
Machine Code Generation
Development

No branches or pull requests
1 participant
@joshuabach