Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

numpy: add new recipe #20283

Open
wants to merge 18 commits into
base: master
Choose a base branch
from
Open

numpy: add new recipe #20283

wants to merge 18 commits into from

Conversation

valgur
Copy link
Contributor

@valgur valgur commented Oct 2, 2023

Specify library name and version: numpy/1.26.4

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

Copy link
Contributor

Hooks produced the following warnings for commit a2d26a0
numpy/1.26.0@#7cdc773a541ba986486337c00040bdca
post_source(): WARN: [SHORT_PATHS USAGE (KB-H066)] The file './vendored-meson/meson/test cases/common/153 wrap file should not failed/subprojects/packagefiles/patchfile/0001-Change-foo-to-executable.patch' has a very long path and may exceed Windows max path length. Add 'short_paths = True' in your recipe.
post_source(): WARN: [SHORT_PATHS USAGE (KB-H066)] The file './vendored-meson/meson/test cases/common/167 subproject nested subproject dirs/contrib/subprojects/alpha/var/subprojects/wrap_files_might_be_here' has a very long path and may exceed Windows max path length. Add 'short_paths = True' in your recipe.
post_source(): WARN: [SHORT_PATHS USAGE (KB-H066)] The file './vendored-meson/meson/test cases/common/98 subproject subdir/subprojects/sub_implicit/subprojects/subsub/subprojects/packagefiles/subsubsub-1.0.zip' has a very long path and may exceed Windows max path length. Add 'short_paths = True' in your recipe.
post_source(): WARN: [SHORT_PATHS USAGE (KB-H066)] The file './vendored-meson/meson/test cases/linuxlike/13 cmake dependency/cmake_pref_env/lib/cmake/cmMesonVersionedTestDep/cmMesonVersionedTestDepConfigVersion.cmake' has a very long path and may exceed Windows max path length. Add 'short_paths = True' in your recipe.

@conan-center-bot

This comment has been minimized.

Copy link
Contributor

Hooks produced the following warnings for commit 65fd909
numpy/1.26.4@#e0487097eae9afead28e663da5e7ad76
post_source(): WARN: [SHORT_PATHS USAGE (KB-H066)] The file './vendored-meson/meson/test cases/common/153 wrap file should not failed/subprojects/packagefiles/patchfile/0001-Change-foo-to-executable.patch' has a very long path and may exceed Windows max path length. Add 'short_paths = True' in your recipe.
post_source(): WARN: [SHORT_PATHS USAGE (KB-H066)] The file './vendored-meson/meson/test cases/common/167 subproject nested subproject dirs/contrib/subprojects/alpha/var/subprojects/wrap_files_might_be_here' has a very long path and may exceed Windows max path length. Add 'short_paths = True' in your recipe.
post_source(): WARN: [SHORT_PATHS USAGE (KB-H066)] The file './vendored-meson/meson/test cases/common/98 subproject subdir/subprojects/sub_implicit/subprojects/subsub/subprojects/packagefiles/subsubsub-1.0.zip' has a very long path and may exceed Windows max path length. Add 'short_paths = True' in your recipe.
post_source(): WARN: [SHORT_PATHS USAGE (KB-H066)] The file './vendored-meson/meson/test cases/linuxlike/13 cmake dependency/cmake_pref_env/lib/cmake/cmMesonVersionedTestDep/cmMesonVersionedTestDepConfigVersion.cmake' has a very long path and may exceed Windows max path length. Add 'short_paths = True' in your recipe.

@conan-center-bot

This comment has been minimized.

Copy link
Contributor

Hooks produced the following warnings for commit f19f86d
numpy/1.26.4@#61dd2cf31315975cdd901cf38ac289de
post_source(): WARN: [SHORT_PATHS USAGE (KB-H066)] The file './vendored-meson/meson/test cases/common/153 wrap file should not failed/subprojects/packagefiles/patchfile/0001-Change-foo-to-executable.patch' has a very long path and may exceed Windows max path length. Add 'short_paths = True' in your recipe.
post_source(): WARN: [SHORT_PATHS USAGE (KB-H066)] The file './vendored-meson/meson/test cases/common/167 subproject nested subproject dirs/contrib/subprojects/alpha/var/subprojects/wrap_files_might_be_here' has a very long path and may exceed Windows max path length. Add 'short_paths = True' in your recipe.
post_source(): WARN: [SHORT_PATHS USAGE (KB-H066)] The file './vendored-meson/meson/test cases/common/98 subproject subdir/subprojects/sub_implicit/subprojects/subsub/subprojects/packagefiles/subsubsub-1.0.zip' has a very long path and may exceed Windows max path length. Add 'short_paths = True' in your recipe.
post_source(): WARN: [SHORT_PATHS USAGE (KB-H066)] The file './vendored-meson/meson/test cases/linuxlike/13 cmake dependency/cmake_pref_env/lib/cmake/cmMesonVersionedTestDep/cmMesonVersionedTestDepConfigVersion.cmake' has a very long path and may exceed Windows max path length. Add 'short_paths = True' in your recipe.

@valgur valgur marked this pull request as ready for review March 21, 2024 15:38
@conan-center-bot

This comment has been minimized.

Copy link
Contributor

Hooks produced the following warnings for commit 0e99851
numpy/1.26.4@#61dd2cf31315975cdd901cf38ac289de
post_source(): WARN: [SHORT_PATHS USAGE (KB-H066)] The file './vendored-meson/meson/test cases/common/153 wrap file should not failed/subprojects/packagefiles/patchfile/0001-Change-foo-to-executable.patch' has a very long path and may exceed Windows max path length. Add 'short_paths = True' in your recipe.
post_source(): WARN: [SHORT_PATHS USAGE (KB-H066)] The file './vendored-meson/meson/test cases/common/167 subproject nested subproject dirs/contrib/subprojects/alpha/var/subprojects/wrap_files_might_be_here' has a very long path and may exceed Windows max path length. Add 'short_paths = True' in your recipe.
post_source(): WARN: [SHORT_PATHS USAGE (KB-H066)] The file './vendored-meson/meson/test cases/common/98 subproject subdir/subprojects/sub_implicit/subprojects/subsub/subprojects/packagefiles/subsubsub-1.0.zip' has a very long path and may exceed Windows max path length. Add 'short_paths = True' in your recipe.
post_source(): WARN: [SHORT_PATHS USAGE (KB-H066)] The file './vendored-meson/meson/test cases/linuxlike/13 cmake dependency/cmake_pref_env/lib/cmake/cmMesonVersionedTestDep/cmMesonVersionedTestDepConfigVersion.cmake' has a very long path and may exceed Windows max path length. Add 'short_paths = True' in your recipe.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot conan-center-bot added the Version conflict There is a version conflict when solving the dependencies graph label May 2, 2024
@conan-center-bot

This comment has been minimized.

@Ahajha
Copy link
Contributor

Ahajha commented May 2, 2024

Conan 2 error is a version conflict, I can put out the necessary PR(s) to fix. Conan 1 error seems to only happen on GCC 9 and 10, but not 11, not quite sure why yet but at least I can reproduce it locally.

@Ahajha
Copy link
Contributor

Ahajha commented May 6, 2024

Little bit of progress: Version range was fixable by just updating to the maintained patch version of cpython (related, maybe we should use version ranges for that? anyways...). The issue that I'm running into on Windows is that it's looking for python3.lib, which exposes potentially a few issues:

  1. python3.lib isn't even packaged (only python3(minor).lib) - easy fix
  2. The source of python3.lib is from a #pragma comment(lib, ...), which in my personal experience generally just cause headaches when trying to do things properly. It uses python3.lib specifically when using the Python Limited API.
  3. Unsure if this is Meson specific, but probably not since a few quick hacks to the cpython package can cause a similar failure.

All in all I think it's (mostly) a cpython package issue, though removing the Py_LIMITED_API definition still causes it to fail with a missing python3.10.lib, so maybe there's some other stuff going on.

Regarding the Conan 2 failure: No clue why it thinks we're raising ConanInvalidConfiguration.

@conan-center-bot conan-center-bot removed the Version conflict There is a version conflict when solving the dependencies graph label May 6, 2024
@conan-center-bot

This comment has been minimized.

@Ahajha
Copy link
Contributor

Ahajha commented May 7, 2024

Added a workaround for a GCC bug (see here: numpy/numpy#16970), I've tested it locally but it now all legacy GCC versions get skipped: numpy itself requires 8.4+, and cpython 3.12+ doesn't work with GCC 9 specifically.

@conan-center-bot conan-center-bot added the Missing dependencies Build failed due missing dependencies in Conan Center label May 7, 2024
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@Ahajha
Copy link
Contributor

Ahajha commented May 14, 2024

@RubenRBS, any idea why the v2 pipeline is failing? As far as I can tell no ConanInvalidConfiguration errors are being thrown. Also need a binary for the v1 pipeline.

@conan-center-bot conan-center-bot removed the Missing dependencies Build failed due missing dependencies in Conan Center label May 19, 2024
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot conan-center-bot added the Missing dependencies Build failed due missing dependencies in Conan Center label May 20, 2024
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ❌

Failure in build 17 (6211d1e7182137195c94f7ca603cc168c4545c58):

  • numpy/1.26.4:
    CI failed to create some packages (All logs)

    Logs for packageID 594894e4d2ed73cca720c70cc1b7dfb26732e619:
    [settings]
    arch=armv8
    build_type=Release
    compiler=apple-clang
    compiler.libcxx=libc++
    compiler.version=13.0
    os=Macos
    
    [...]
        libxcrypt/4.4.36 from 'conan-center' - Cache
        mpdecimal/2.5.0 from 'conan-center' - Cache
        ncurses/6.4 from 'conan-center' - Cache
        ninja/1.11.1 from 'conan-center' - Downloaded
        openssl/3.2.1 from 'conan-center' - Cache
        pkgconf/2.1.0 from 'conan-center' - Downloaded
        sqlite3/3.45.2 from 'conan-center' - Cache
        tcl/8.6.10 from 'conan-center' - Cache
        tk/8.6.10 from 'conan-center' - Cache
        xz_utils/5.4.5 from 'conan-center' - Cache
        zlib/1.3.1 from 'conan-center' - Cache
    Build requirements packages
        bzip2/1.0.8:2b8e4ed96946ad0a4cd2c6e1e01636aa2a421589 - Download
        cpython/3.12.2:7d0247e631e5f3c7af03afa8d851b80777e11c0b - Missing
        expat/2.6.2:38ab6a38f66c07eba71698df5ea91b7fed6840bf - Download
        gdbm/1.23:e83c77cd80a8eb63edac66c97837c317c3f7c1b2 - Download
        libffi/3.4.4:095512ed878f14a09dd732e9f6868729dd437529 - Download
        libxcrypt/4.4.36:095512ed878f14a09dd732e9f6868729dd437529 - Download
        mpdecimal/2.5.0:2557da8d3b48c6b94a88ace362097353aa68b458 - Download
        ncurses/6.4:1f2a0268546d6dd0013f3345d99976861ce2a24d - Download
        ninja/1.11.1:3eb32b976fb0626f3c40a8b87ace72156aa44204 - Download
        openssl/3.2.1:6e01680e043d97040ec80bae3f0e3344aa118d38 - Download
        pkgconf/2.1.0:3eb32b976fb0626f3c40a8b87ace72156aa44204 - Download
        sqlite3/3.45.2:509c6f4636dec8645bfd459c6049cbef21b8ce1b - Download
        tcl/8.6.10:64ec77f7e5dd73b212e97011317e08b461c245b7 - Download
        tk/8.6.10:0e1cb6ca2df2143a049ee16f6ebc59d1d2f986fd - Download
        xz_utils/5.4.5:095512ed878f14a09dd732e9f6868729dd437529 - Download
        zlib/1.3.1:095512ed878f14a09dd732e9f6868729dd437529 - Download
    
    Installing (downloading, building) binaries...
    
    WARN: *** Conan 1 is legacy and on a deprecation path ***
    WARN: *** Please upgrade to Conan 2 ***
    WARN: openssl/3.2.1: requirement zlib/[>=1.2.11 <2] overridden by cpython/3.12.2 to zlib/1.3.1 
    WARN: tcl/8.6.10: requirement zlib/[>=1.2.11 <2] overridden by tk/8.6.10 to zlib/1.3.1 
    WARN: openssl/3.2.1: requirement zlib/[>=1.2.11 <2] overridden by cpython/3.12.2 to zlib/1.3.1 
    WARN: tcl/8.6.10: requirement zlib/[>=1.2.11 <2] overridden by tk/8.6.10 to zlib/1.3.1 
    ERROR: Missing binary: cpython/3.12.2:7d0247e631e5f3c7af03afa8d851b80777e11c0b
    cpython/3.12.2: WARN: Can't find a 'cpython/3.12.2' package for the specified settings, options and dependencies:
    - Settings: arch=armv8, build_type=Release, compiler=apple-clang, compiler.version=13, os=Macos
    - Options: docstrings=True, env_vars=True, fPIC=True, lto=False, optimizations=False, pymalloc=True, shared=False, with_bz2=True, with_curses=True, with_gdbm=True, with_lzma=True, with_nis=False, with_sqlite3=True, with_tkinter=True, bzip2:build_executable=True, bzip2:fPIC=True, bzip2:shared=False, expat:char_type=char, expat:fPIC=True, expat:large_size=False, expat:shared=False, gdbm:fPIC=True, gdbm:gdbmtool_debug=True, gdbm:libgdbm_compat=False, gdbm:shared=False, gdbm:with_libiconv=False, gdbm:with_nls=True, gdbm:with_readline=False, libffi:fPIC=True, libffi:shared=False, libxcrypt:fPIC=True, libxcrypt:shared=False, mpdecimal:cxx=True, mpdecimal:fPIC=True, mpdecimal:shared=False, ncurses:fPIC=True, ncurses:shared=False, ncurses:with_cxx=True, ncurses:with_extended_colors=True, ncurses:with_pcre2=False, ncurses:with_progs=True, ncurses:with_reentrant=False, ncurses:with_ticlib=True, ncurses:with_tinfo=True, ncurses:with_widec=True, openssl:386=False, openssl:enable_trace=False, openssl:enable_weak_ssl_ciphers=False, openssl:fPIC=True, openssl:no_apps=False, openssl:no_aria=False, openssl:no_asm=False, openssl:no_async=False, openssl:no_autoload_config=False, openssl:no_bf=False, openssl:no_blake2=False, openssl:no_camellia=False, openssl:no_cast=False, openssl:no_chacha=False, openssl:no_cms=False, openssl:no_comp=False, openssl:no_ct=False, openssl:no_deprecated=False, openssl:no_des=False, openssl:no_dgram=False, openssl:no_dh=False, openssl:no_dsa=False, openssl:no_dso=False, openssl:no_ec=False, openssl:no_ecdh=False, openssl:no_ecdsa=False, openssl:no_engine=False, openssl:no_filenames=False, openssl:no_fips=False, openssl:no_gost=False, openssl:no_idea=False, openssl:no_legacy=False, openssl:no_md2=True, openssl:no_md4=False, openssl:no_mdc2=False, openssl:no_module=False, openssl:no_ocsp=False, openssl:no_pinshared=False, openssl:no_rc2=False, openssl:no_rc4=False, openssl:no_rc5=False, openssl:no_rfc3779=False, openssl:no_rmd160=False, openssl:no_seed=False, openssl:no_sm2=False, openssl:no_sm3=False, openssl:no_sm4=False, openssl:no_sock=False, openssl:no_srp=False, openssl:no_srtp=False, openssl:no_sse2=False, openssl:no_ssl=False, openssl:no_ssl3=False, openssl:no_stdio=False, openssl:no_threads=False, openssl:no_tls1=False, openssl:no_ts=False, openssl:no_whirlpool=False, openssl:no_zlib=False, openssl:openssldir=None, openssl:shared=False, openssl:tls_security_level=None, sqlite3:build_executable=True, sqlite3:disable_gethostuuid=False, sqlite3:enable_column_metadata=True, sqlite3:enable_dbpage_vtab=False, sqlite3:enable_dbstat_vtab=False, sqlite3:enable_default_secure_delete=False, sqlite3:enable_default_vfs=True, sqlite3:enable_explain_comments=False, sqlite3:enable_fts3=False, sqlite3:enable_fts3_parenthesis=False, sqlite3:enable_fts4=False, sqlite3:enable_fts5=False, sqlite3:enable_json1=False, sqlite3:enable_math_functions=True, sqlite3:enable_preupdate_hook=False, sqlite3:enable_rtree=True, sqlite3:enable_soundex=False, sqlite3:enable_unlock_notify=True, sqlite3:fPIC=True, sqlite3:max_blob_size=None, sqlite3:max_column=None, sqlite3:max_variable_number=None, sqlite3:omit_deprecated=False, sqlite3:omit_load_extension=False, sqlite3:shared=False, sqlite3:threadsafe=1, sqlite3:use_alloca=False, sqlite3:use_uri=False, tcl:fPIC=True, tcl:shared=False, tk:fPIC=True, tk:shared=False, xz_utils:fPIC=True, xz_utils:shared=False, zlib:fPIC=True, zlib:shared=False
    - Dependencies: zlib/1.3.1, openssl/3.2.1, expat/2.6.2, libffi/3.4.4, mpdecimal/2.5.0, libxcrypt/4.4.36, bzip2/1.0.8, gdbm/1.23, sqlite3/3.45.2, tk/8.6.10, ncurses/6.4, xz_utils/5.4.5
    - Requirements: bzip2/1.Y.Z, expat/2.Y.Z, gdbm/1.Y.Z, libffi/3.Y.Z, libxcrypt/4.Y.Z, mpdecimal/2.Y.Z, ncurses/6.Y.Z, openssl/3.Y.Z, sqlite3/3.Y.Z, tk/8.Y.Z, xz_utils/5.Y.Z, zlib/1.Y.Z
    - Package ID: 7d0247e631e5f3c7af03afa8d851b80777e11c0b
    
    ERROR: Missing prebuilt package for 'cpython/3.12.2'
    Use 'conan search cpython/3.12.2@ --table=table.html -r=remote' and open the table.html file to see available packages
    Or try to build locally from sources with '--build=cpython'
    
    More Info at 'https://docs.conan.io/en/latest/faq/troubleshooting.html#error-missing-prebuilt-package'
    

Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.


Conan v2 pipeline ❌

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

The v2 pipeline failed. Please, review the errors and note this is required for pull requests to be merged. In case this recipe is still not ported to Conan 2.x, please, ping @conan-io/barbarians on the PR and we will help you.

See details:

Failure in build 17 (6211d1e7182137195c94f7ca603cc168c4545c58):

  • numpy/1.26.4:
    Do not raise ConanInvalidConfiguration from build() method. Please, move that same check to validate() method.

Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.

@RubenRBS RubenRBS self-assigned this May 20, 2024
@Ahajha
Copy link
Contributor

Ahajha commented May 21, 2024

@valgur BTW I believe this should work on all platforms, in case you wanted to add it to your new recipe repo. I've at least tested locally with Windows/VS2022/x64/Release + Linux/GCC(several)/x64/Release + Mac/apple-clang(15)/armv8/Release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Failed Missing dependencies Build failed due missing dependencies in Conan Center
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants