Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git: new recipe #23828

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

git: new recipe #23828

wants to merge 15 commits into from

Conversation

Ahajha
Copy link
Contributor

@Ahajha Ahajha commented Apr 30, 2024

Specify library name and version: git/2.45.1

Resolves #23601

Note: The one potentially relevant patch has not been submitted upstream. Frankly, Git's mailing list scares me, and I don't think the changes here would be robust enough to be accepted, but should be good enough for our usage.

I am unsure what to do about some of the packaged files, as some seem harmless but are picked up by the hook, while some are bloating the package but could be useful. Here's the tree output on Linux, omitting the rmdirs in the package() step (the contents of bin I believe should be agreeably useful):
tree.txt

The libexec/git-core folder would likely need to be added to the path if we decide to keep it. These commands seem to be part of the normal Git installation (though on my machine they aren't on they're not on path for some reason). There's also a duplicate git, so maybe only one of them is intended to be used? These are a ton of essentially extra copies of git, which greatly bloats the package size. I think it's fine to omit these, but would love input.

The share folder seems harmless (not big at all) but doesn't really contain much that would likely be useful for Conan users, mainly some perl scripts and some samples from what I can tell. Probably best to just make the hook happy and remove it.


@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@Ahajha Ahajha marked this pull request as ready for review May 19, 2024 08:21
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 16 (84bb36638fa43193dcee62ab401619aeaf738d46):

  • git/2.45.1:
    All packages built successfully! (All logs)

Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 16 (84bb36638fa43193dcee62ab401619aeaf738d46):

  • git/2.45.1:
    All packages built successfully! (All logs)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[request] git/2.44.0
2 participants