Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libwebsocket: actually build 4.3.2 and later #23968

Merged
merged 2 commits into from May 14, 2024

Conversation

ericLemanissier
Copy link
Contributor

@ericLemanissier ericLemanissier commented May 13, 2024

fixes #23967

Specify library name and version: libwebsocket/*

@jcar87 you are the original author of this line, so you probably want to take a look at the fix


@ericLemanissier
Copy link
Contributor Author

The build is now finished. You can take a look at the results here

@conan-center-bot

This comment has been minimized.

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 3 (43cb281324df2154f6e86ae85dc8c4de254ab6d6):

  • libwebsockets/4.3.2:
    All packages built successfully! (All logs)

  • libwebsockets/4.3.3:
    All packages built successfully! (All logs)

  • libwebsockets/4.3.0:
    All packages built successfully! (All logs)

  • libwebsockets/4.2.1:
    All packages built successfully! (All logs)

  • libwebsockets/4.2.0:
    All packages built successfully! (All logs)


Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 3 (43cb281324df2154f6e86ae85dc8c4de254ab6d6):

  • libwebsockets/4.3.3:
    All packages built successfully! (All logs)

  • libwebsockets/4.3.2:
    All packages built successfully! (All logs)

  • libwebsockets/4.3.0:
    All packages built successfully! (All logs)

  • libwebsockets/4.2.1:
    All packages built successfully! (All logs)

  • libwebsockets/4.2.0:
    All packages built successfully! (All logs)

@ericLemanissier
Copy link
Contributor Author

@uilianries @RubenRBS what do you think of this fix ? This is quite urgent because all consumers of libwebsocket >= 4.3.2 fall in ConanInvalidConfiguration exception currently.

Copy link
Member

@RubenRBS RubenRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving after looking into it with @czoido

@conan-center-bot conan-center-bot merged commit 6c1187c into conan-io:master May 14, 2024
33 checks passed
@ericLemanissier
Copy link
Contributor Author

Thanks !

@ericLemanissier ericLemanissier deleted the libwebsocket branch May 14, 2024 10:37
@RubenRBS RubenRBS self-assigned this May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[package] libwebsockets recipe validation seems like it could be broken
6 participants