Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[package] libwebsockets recipe validation seems like it could be broken #23967

Closed
robinnorthcottqube opened this issue May 13, 2024 · 0 comments · Fixed by #23968
Closed

[package] libwebsockets recipe validation seems like it could be broken #23967

robinnorthcottqube opened this issue May 13, 2024 · 0 comments · Fixed by #23968

Comments

@robinnorthcottqube
Copy link

I think this is the wrong way around. Should fail if the version condition is not met.

conan-center-index/recipes/libwebsockets/all/conanfile.py

Line 240 in 0cfb431

if check_min_vs(self, "192", raise_invalid=False):

@robinnorthcottqube robinnorthcottqube changed the title libwebsockets validation seems like it could be broken [package] libwebsockets recipe validation seems like it could be broken May 13, 2024
ericLemanissier added a commit to ericLemanissier/conan-center-index that referenced this issue May 13, 2024
@ericLemanissier
libwebsocket: actually build 4.3.2 and later
44df62d 
fixes conan-io#23967
@ericLemanissier ericLemanissier mentioned this issue May 13, 2024
Merged
3 tasks
conan-center-bot pushed a commit that referenced this issue May 14, 2024
@ericLemanissier
(#23968) libwebsocket: actually build 4.3.2 and later
6c1187c 
fixes #23967
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

libwebsocket: actually build 4.3.2 and later ericLemanissier/conan-center-index
1 participant
@robinnorthcottqube