Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[package] boost/1.83.0 build failed with gcc==4.8 #23973

Closed
Rickylss opened this issue May 13, 2024 · 2 comments · Fixed by #23975
Closed

[package] boost/1.83.0 build failed with gcc==4.8 #23973

Rickylss opened this issue May 13, 2024 · 2 comments · Fixed by #23975
Assignees
Labels
bug Something isn't working

Comments

@Rickylss
Copy link

Description

Build boost/1.83.0 failed with gcc==4.8.

Package and Environment Details

  • Package Name/Version: boost/1.83.0
  • Operating System+version: Linux Ubuntu 16.04
  • Compiler+version: GCC 4.8
  • Conan version: conan 1.59.0
  • Python version: Python 2.7.12

Conan profile

[settings]
arch=x86_64
arch_build=x86_64
build_type=Release
compiler=gcc
compiler.libcxx=libstdc++
compiler.version=4.8
os=Linux
os_build=Linux
[options]
[build_requires]
[env]

Steps to reproduce

conan install -r conancenter boost/1.83.0@ -pr:b=default -pr:h=default

Logs

企业微信截图_17156010749901

@Rickylss Rickylss added the bug Something isn't working label May 13, 2024
@Rickylss
Copy link
Author

By examining the code, I have discovered that the issue is caused by an incorrect judgment.

index 48dad5b67..9154a553e 100644
--- a/recipes/boost/all/conanfile.py
+++ b/recipes/boost/all/conanfile.py
@@ -265,7 +265,7 @@ class BoostConan(ConanFile):
             return valid_min_cppstd(self, 11)
         compiler_version = self._min_compiler_version_default_cxx11
         if compiler_version:
-            return (Version(self.settings.compiler.version) >= compiler_version) or "11" in supported_cppstd(self)
+            return (Version(self.settings.compiler.version) >= compiler_version) and "11" in supported_cppstd(self)
 
     @property
     def _has_cppstd_14_supported(self):

I have fixed this issue by making the modifications mentioned above.

@uilianries uilianries self-assigned this May 13, 2024
@uilianries
Copy link
Member

@Rickylss Thank you for providing an analyze over the case. I'll take a look on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants