Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating multiple BenchmarkResult instances is slow #1600

Open
assignUser opened this issue Apr 9, 2024 · 1 comment
Open

Creating multiple BenchmarkResult instances is slow #1600

assignUser opened this issue Apr 9, 2024 · 1 comment

Comments

@assignUser
Copy link

During local testing I noticed that creating ~1k BenchmarkResult() instances takes 30+s. This is of course nothing really super bad but after a cursory look I think the main reason for the slow down is the gathering of system info. This could obviously be cached/memoized no reason to call git a thousand times, the hardware is pretty unlikely to change within one run ^_^

@austin3dickey
Copy link
Member

Yikes! Yes, related: #655 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants