Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better factor Dataset.download() to make testing it easier #114

Open
jonkeane opened this issue Oct 20, 2022 · 0 comments
Open

Better factor Dataset.download() to make testing it easier #114

jonkeane opened this issue Oct 20, 2022 · 0 comments

Comments

@jonkeane
Copy link
Contributor

I would propose we have a method that does the downloading and no validation or anything (maybe Dataset._download()`), and then we wrap that with the validation etc. stuff later (so then when we test that we only need to mock the actual downloading bit and not also permissions+metadata writing+permissions munging).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant